1552853 - Update downloads get stuck at 'Applying update' state in the UI (updates continue to work) when Mozilla Maintenance Service is disabled

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect, P1)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: bitsaplyingstate02.gif

Affected versions

• Firefox 68.0b1 (20190513111358)
• Firefox 68.0a1 (20190518102559)

Affected platforms

• Windows 10x64
• Windows 7x64

Preconditions

• Install an older version of Firefox ex (Firefox 68.0b1 (20190513111358) or Firefox 68.0a1 (20190511220902)).
• Disable Mozilla Maintenance Service.

Steps to reproduce

1. Launch Firefox and open browser console.
2. Wait for the update download to complete and wait for about 10 seconds after completion.
3. Click the about Firefox button from the Hamburger > Help menu.

Expected result

• The message “Restart to update Firefox” is displayed.

Actual result

• On Nightly builds - The “Restart to update” message appears in the hamburger menu and is accessible, but accessing the Help menu shows the “Applying update...” in an endless loop state.
• On Beta/Deved builds - The “Restart to update” message does not appear in the hamburger menu and accessing the Help menu displays the “Applying update...” in an endless loop state.

Regression Range

• Last good revision: 2abcefb31ba7b2a1c573edc5695b772826c6a078 (2019-05-10)
• First bad revision: 4440662cd0177f3fc3200cff190daed47d71a167 (2019-05-11)
• Pushlog:
  https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2abcefb31ba7b2a1c573edc5695b772826c6a078&tochange=4440662cd0177f3fc3200cff190daed47d71a167
• Potential regressor: bug 1546627.

Additional Notes

• Attached a screen recording with this issue.
• Restarting or closing the browser makes UAC appear and if “Yes” option is clicked, the browser is updated.
• The issue is reproducible using both nsIIncrementalDownload and BITS.

Comment 1

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: update_log.txt

Hi Kirk,

It is possible that this may have been caused by the fix from bug 1546627.

Can you please have a look?

Thanks!

Comment 2

[Robert Strong (they/them - no direct email)]

Thanks, I'll take this.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: Bug 1552853 - Fix the update UI so it displays restart when it should when update staging fails. r=mhowell

Fixes the case reported where disabling the maintenance service caused the UI to display Applying due to the update staging failure.
Added new error codes for the two cases where pending was written to the update.status file when staging failed.
Added code to UpdateService.jsm to set the update.status to pending when either of the two new error codes are in the update.status file.
Added two new tests that verify the UI and simulate the failure condition in updater.cpp.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebeb4133719f
Fix the update UI so it displays restart when it should when update staging fails. r=mhowell

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ebeb4133719f

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 9066783 [details]
Bug 1552853 - Fix the update UI so it displays restart when it should when update staging fails. r=mhowell

Beta/Release Uplift Approval Request

• User impact if declined: Clients can get into a state where the UI shows Applying instead of Restart when update staging fails due to the maintenance service being disabled.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: From comment #0

Preconditions

Install an older version of Firefox ex (Firefox 68.0b1 (20190513111358) or Firefox 68.0a1 (20190511220902)).
Disable Mozilla Maintenance Service.

Steps to reproduce

Launch Firefox and open browser console.
Wait for the update download to complete and wait for about 10 seconds after completion.
Click the about Firefox button from the Hamburger > Help menu.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): There were 2 instances where the updater set the update to pending when there was an error so it would be instead applied on restart. This patch sets those two cases to an error and it changes UpdateService.jsm to handle these two errors like it already does for other errors.
• String changes made/needed: None

Comment 7

[Alexandru Trif, Desktop QA [:atrif]]

Hello,
I just want to point out that we can't use the same builds from preconditions. We need 2 fixed builds to successfully verify the bug. The same conditions apply on Nightly and Beta. I will begin testing when there are available 2 builds containing the fix. Or is there any other way to test this?
Thank you!

Comment 8

[Alexandru Trif, Desktop QA [:atrif]]

Hello,

The issue is verified when updating from Firefox 69.0a1 (20190524214959) to Firefox 69.0a1 (20190526211422) using both nsIIncrementalDownload and BITS on Windows 10 x64 and Windows 7 x64.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9066783 [details]
Bug 1552853 - Fix the update UI so it displays restart when it should when update staging fails. r=mhowell

updater fix, approved for 68.0b5

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b03b23d73d3c

Comment 11

[Alexandru Trif, Desktop QA [:atrif]]

The issue is verified when updating from Firefox 68.0b5 (20190527103257) to Firefox 68.0b6 (20190529145824) using both nsIIncrementalDownload and BITS on Windows 10 x64 and Windows 7 x64.