Closed Bug 1552888 Opened 5 years ago Closed 5 years ago

[Cards] Typography and padding adjustments

Categories

(Firefox :: New Tab Page, enhancement, P1)

67 Branch
enhancement

Tracking

()

VERIFIED FIXED
Firefox 69
Iteration:
69.1 - May 13 - 26
Tracking Status
firefox69 --- verified

People

(Reporter: wolasi, Assigned: gsuntop)

References

Details

(Keywords: github-merged)

Attachments

(2 files, 1 obsolete file)

Please make the following changes to the card format

All Bordered Cards
Meta left and right padding should be 16px

Big Hero Card and 3-col Card

  • Change excerpt font-size to 15px and line-height to 24px
  • Verify that this doesn't break line clamping
Assignee: nobody → gsuntop
Type: defect → enhancement
Iteration: --- → 69.1 - May 13 - 26
Priority: -- → P1
Attached image 1552888-round1.png (obsolete) —
Attachment #9066857 - Flags: ui-review?(wkonu)

Commented on the pr re: padding
Font-size and line-height changes look good

Flags: needinfo?(gsuntop)
Attached image 1552888-round2.jpg
Attachment #9066857 - Attachment is obsolete: true
Attachment #9066857 - Flags: ui-review?(wkonu)
Flags: needinfo?(gsuntop)
Attachment #9066888 - Flags: ui-review?(wkonu)
Blocks: 69-ds-polish
No longer blocks: 69-ds-polish
Blocks: 69-ds-polish
Blocks: 1554322
Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

I have verified this issue with the latest Firefox Nightly (69.0a1 Build ID - 20190530214830) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the cards are respecting the specifications from comment 0.

Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
Attachment #9066888 - Flags: ui-review?(wkonu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: