Closed Bug 1552960 Opened 1 year ago Closed 1 year ago

Build bustage after bug 1551738: Exception: No platform matching u'thunderbird-source' nor 'default' found while determining item `s3_bucket_paths` in `s3_bucket_paths`


(Thunderbird :: Build Config, defect)

Not set


(Not tracked)

Thunderbird 69.0


(Reporter: jorgk-bmo, Assigned: jorgk-bmo)




(Keywords: regression)


(4 files, 2 obsolete files)

Attached patch WIP, not working all all. (obsolete) — Splinter Review

Running the taskcluster tool locally, I get:
0:03.91 Error loading tasks for kind beetmover-source:
Exception: No platform matching u'thunderbird-source' nor 'default' found while determining item s3_bucket_paths in s3_bucket_paths

I tried to port a few bits of bug 1551738 with no success. I'll attach a WIP.

Try runs:

This may also need M-C changes, perhaps here:

Maybe Geoff wants to spend some time on this. Or Tom can give us a hint.

Flags: needinfo?(rob)
Flags: needinfo?(mozilla)
Flags: needinfo?(geoff)

Ported some from here: but still with "Firefox" in the config which doesn't appear to be right.

Rather than modifying m-c, the solution is to copy the artifact manifest to c-c, and change the artifact_map's to point at the c-c copies.

Flags: needinfo?(mozilla)
Attached patch pp.patch (obsolete) — Splinter Review

Thanks, Tom. This one works but needs some clean-up.

Assignee: nobody → jorgk
Attachment #9066190 - Attachment is obsolete: true
Flags: needinfo?(rob)
Flags: needinfo?(geoff)
Attached patch pp.patchSplinter Review

I'm going to land this now and then Rob can to a clean-up around the edges.

Attachment #9066207 - Attachment is obsolete: true

Pushed by
Port parts of bug 1551738 (rev 7144d26d331ccd17dc9c5b3a79f424fc53a0f1dc) and add artifact manifests. rs=bustage-fix

Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0
Pushed by
Follow-up: remove yaml separator --- from copied files. rs=bustage-fix DONTBUILD
Attached patch 36375.patchSplinter Review

We don't need the custom transform function anymore. Removing it will fix the validation error as the .xpi file was listed twice.

Attachment #9066474 - Flags: review?(jorgk)
Comment on attachment 9066474 [details] [diff] [review]

OK. Are you actually saying that all the stuff I landed was alright? Have you looked at it? Does some of it need to be removed? I just dumped all the FF files in with only some minor tweaks.
Attachment #9066474 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
Attached patch 36376.patchSplinter Review

It was trying to upload checksums to an s3 bucket named "default" instead of "pub/thunderbird/nightly"

Attachment #9066483 - Flags: review?(jorgk)
Comment on attachment 9066483 [details] [diff] [review]

Interesting, I should really know more about that stuff.
Attachment #9066483 - Flags: review?(jorgk) → review+
Attached patch 36377.patchSplinter Review

Cleaned up the manifest files.

Attachment #9066512 - Flags: review?(jorgk)
Comment on attachment 9066512 [details] [diff] [review]

Thanks, I knew some of that stuff needed to be pulled out, but at 12:30 AM I didn't have the patience.
Attachment #9066512 - Flags: review?(jorgk) → review+

Pushed by
Follow-up: Remove custom Thunderbird Langpack transform. r=jorgk
Follow-up: Fix S3 bucket path for checksum uploads. r=jorgk
Follow-up: Cleanup Beetmover manifests. r=jorgk
Follow-up: Restore yaml separator --- since it's required now. r=me DONTBUILD

Keywords: checkin-needed
Regressed by: 1567725
Keywords: regression
You need to log in before you can comment on or make changes to this bug.