Closed Bug 1552987 Opened 2 years ago Closed 2 years ago

Jump-to-function-definition buttons are no longer visible in the console


(DevTools :: Console, defect, P2)



(firefox-esr60 unaffected, firefox67+ wontfix, firefox68+ verified, firefox69- verified)

Firefox 69
Tracking Status
firefox-esr60 --- unaffected
firefox67 + wontfix
firefox68 + verified
firefox69 - verified


(Reporter: wartmanm, Assigned: jlast)




(Keywords: regression, Whiteboard: [qa-triaged])


(3 files)

What were you doing?

I entered a function name in the console, hoping to be able to jump straight to it.

What happened?

The jump-to-function-definition button is invisible. I was still able to get to the function, but it involved a certain amount of blind clicking.

Anything else we should know?

The other locations that I know about where the icon is used, like event popups in the inspector, are fine. So are other icons in the console, like the jump-to-inspector icon on DOM nodes.

This happens on a clean profile and in both light and dark themes. I think it was caused by the CSS changes in bug 1548438: the button.jumpDefinition style no longer sets a stroke, so I think it's no longer passing anything in to the svg's context-stroke, or else whatever it passes in doesn't work for drawing a mask.

It looks like reverted parts of

ni? Logan, it doesn't seem like this was intentional – were they pulled in from github?

Flags: needinfo?(lsmyth)
Keywords: regression
Priority: -- → P2

Yep, looks like the changes should have been made in The files in shared are build artifacts and are overwritten on build.

Jason, you up for reverting that part of your patch and updating reps?

Flags: needinfo?(lsmyth) → needinfo?(jlaster)

67 is impacted. When this bug is fixed, we should probably uplift it.

Ever confirmed: true
OS: Unspecified → All
Regressed by: 1548438
Hardware: Unspecified → All

Logan, on it.

Flags: needinfo?(jlaster)
Pushed by
Jump-to-function-definition buttons are no longer visible in the console. r=nchevobbe

[Tracking Requested - why for this release]: Broken CSS hides a button in Console that developers need to jump to functions definitions in the Debugger. We expect that advanced users depend on this functionality, but only occasionally.

Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Assignee: nobody → jlaster

re-opening so that we can uplift

Resolution: FIXED → ---

The bug can/should remain closed for the uplifts, if it's fixed in central.

Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Attached patch jump-1.patchSplinter Review

Beta/Release Uplift Approval Request

  • User impact if declined: users wont see the jump-to-definition button
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): it only affects the console
  • String changes made/needed:
Attachment #9067039 - Flags: approval-mozilla-beta?

Slightly confused as this is listed as regressed by 1548438, which is only in 68, but 67 is marked as affected.

Comment on attachment 9067039 [details] [diff] [review]

devtools console css fix, approved for 68.0b5
Attachment #9067039 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Whiteboard: [qa-triaged]

Fix verified with 68.06, 69.0a1 (2019-05-27) on Windows 10, macOS 10.13, Ubuntu 16.04.

Flags: qe-verify+

Cristi, can you double check that 67 is affected? Thanks!

Flags: needinfo?(cristian.fogel)

67.0(20190516215225) and 67.0.1(20190529130856) are not affected.

Flags: needinfo?(cristian.fogel)
You need to log in before you can comment on or make changes to this bug.