1553000 - Calendar tab doesn't always restore to the right view

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan)]

I usually leave my calendar tab open, and on the multi-week view. I've noticed that sometimes when I start Thunderbird the calendar tab has the week or day view.

We get the view to show (in getLastCalendarView) from the selected index of view-deck, which in turn gets it from the XUL store via the overlay loader. The overlay loader itself has special handling for <deck> elements. There's some timing issue here.

I've tried modifying getLastCalendarView to directly query the XUL store but I think even that doesn't work every time. I wonder if we should just skip the XUL store altogether and keep the most-recently-used view in a pref.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1553000-last-calendar-view-1.diff

This might be more effective than I thought. In any case I think it's worth doing.

Comment 2

[Stefan Sitter [:ssitter]]

Related to or same as Bug 1549082?

Comment 3

[Geoff Lankow (:darktrojan)]

Quite possibly related, although there's some differences.

My proposed solution failed again today, so it's not perfect but it seems more reliable than it was.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 9067253 [details] [diff] [review]
1553000-last-calendar-view-1.diff

Review of attachment 9067253 [details] [diff] [review]:
-----------------------------------------------------------------

I'm fine with using a pref as well.

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9067253 [details] [diff] [review]
1553000-last-calendar-view-1.diff

Look what I forgot to set (again).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8503388a3844
Get last-used calendar view directly from the XUL store. r=philipp

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68 beta / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/bad5bfd2b1bbc4c57468fcf2ef4e436dc14be667