Closed Bug 1553001 Opened 3 months ago Closed 3 months ago

Move public module-related APIs to their own header/cpp files

Categories

(Core :: JavaScript Engine, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: Waldo, Assigned: Waldo)

Details

Attachments

(1 file)

I'm touching/using these APIs in UTF-8 compiling patchwork, and I'm kind of drowning. Split them out to their own thing to help, and for the reduction of jsapi.h size and everyone depending on it.

There are probably other things in builtin/ModuleObject.* that could stand to move into this .cpp as well, but I don't want to drag this out too long. Also because this properly copies jsapi.{cpp,h}, it's a bit bitrot-prone. Fast review appreciated here!

Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/719664f29265
Move module APIs out of jsapi.{cpp,h} into js/public/Modules.h and js/src/vm/Modules.cpp for better isolation of module-related APIs.  r=arai
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.