1553009 - Replace double quotes with single quotes in toolkit/locales/l10n.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1553009 - Replace double quotes with single quotes in toolkit/locales/l10n.mk.

Like bug 943728.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daa4425ac56d
Replace double quotes with single quotes in toolkit/locales/l10n.mk. r=nalexander

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/daa4425ac56d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9066269 [details]
Bug 1553009 - Replace double quotes with single quotes in toolkit/locales/l10n.mk.

Beta/Release Uplift Approval Request

• User impact if declined: No impact on end users, just a developer quality-of-life issue. We need to update mozmake to a newer version in bug 1551388 to support ongoing PGO work, but l10n repacks (and |./mach package|) break without this change. It would be nice if we could update mozmake in MozillaBuild without breaking their ability to build 68/ESR60 still. If we don't take this uplift, developers will need to keep an older version of MozillaBuild installed to build older supported repos, potentially until the end of next year if this doesn't make it to 68.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): We've got green l10n jobs on m-c already since this landed. Any issues with the patch should be readily apparent in CI.
• String changes made/needed: None

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9066269 [details]
Bug 1553009 - Replace double quotes with single quotes in toolkit/locales/l10n.mk.

approved for 68.0b4

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eacd30627fc6

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9066269 [details]
Bug 1553009 - Replace double quotes with single quotes in toolkit/locales/l10n.mk.

Ensures that |./mach package| still works with newer versions of mozmake. Baked on Nightly and Beta without issue. Approved for 60.8esr.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/357471cac18c