Closed Bug 1553011 Opened 6 months ago Closed 5 months ago

Import new version of our Rust based SDP parser

Categories

(Core :: WebRTC: Signaling, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: ng, Assigned: ng)

References

Details

Attachments

(2 files)

A number of small improvements have been made to the Rust SDP parser, we should update our import.

update import of Rust SDP parser

Assignee: nobody → na-g

Nils, I checked phabricator and it says that you reviewed this, but that is not reflected in Bugzilla for me. Interesting.

Flags: needinfo?(drno)
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/1691176e9819
update import of Rust SDP parser - r=drno

Fixing that failure, revealed more failures. I am working through those.

Flags: needinfo?(drno)
Attachment #9068580 - Attachment is obsolete: true
Flags: needinfo?(na-g)
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/09e682ea9d23
update import of Rust SDP parser - r=drno
Flags: needinfo?(na-g)
Blocks: 1556598

The state of tests on Treeherder right now is very noisy. I looked through the errors and I didn't find anything related, though with so many, it is possible that one slipped through.

Flags: needinfo?(na-g)
Attachment #9068580 - Attachment is obsolete: false
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/9e968a4d00bc
update import of Rust SDP parser - r=drno

Now passing
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9aeaae18c26c288d734f7de9da0fa73ec4498e42
I also wrote a script to comb the the try failures for anything SDP related.

Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/b6559295ac78
update import of Rust SDP parser - r=drno
Pushed by na-g@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/ab06ddac5f0f
update import of Rust SDP parser - r=drno
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.