Import new version of our Rust based SDP parser
Categories
(Core :: WebRTC: Signaling, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: ng, Assigned: ng)
References
Details
Attachments
(2 files)
A number of small improvements have been made to the Rust SDP parser, we should update our import.
Assignee | ||
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a30a919125e3d95cf4072548a281a3b637a5547
Assignee | ||
Comment 2•5 years ago
|
||
update import of Rust SDP parser
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Nils, I checked phabricator and it says that you reviewed this, but that is not reflected in Bugzilla for me. Interesting.
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/1691176e9819 update import of Rust SDP parser - r=drno
Comment 5•5 years ago
|
||
Backed out changeset 1691176e9819 (Bug 1553011) for GTest crashes.
Backout: https://hg.mozilla.org/integration/autoland/rev/9617ee5d9b886a899730077b207655222d27867a
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=1691176e981921c197cce3eed36f709c89a18dd2&selectedJob=247699199
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247699199&repo=autoland&lineNumber=1224
Assignee | ||
Comment 6•5 years ago
|
||
Fixing that failure, revealed more failures. I am working through those.
Assignee | ||
Comment 7•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 8•5 years ago
|
||
Assignee | ||
Comment 9•5 years ago
|
||
Assignee | ||
Comment 10•5 years ago
|
||
Note that the test failures happen without the patch as well: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f06229b8fca766d032eb7cba9f9785097e7e7ea
Comment 11•5 years ago
|
||
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/09e682ea9d23 update import of Rust SDP parser - r=drno
Comment 12•5 years ago
|
||
Backed out changeset 09e682ea9d23 for spidermonkey bustages.
Backout link: https://hg.mozilla.org/integration/autoland/rev/f901cef144f10d625912f76398ef4a67df6225a8
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=spidermonkey%2Cdebug&revision=09e682ea9d23f712f0b36bbfe8a62187c283182d
Failure logs
Updated•5 years ago
|
Assignee | ||
Comment 13•5 years ago
|
||
Assignee | ||
Comment 14•5 years ago
|
||
Assignee | ||
Comment 15•5 years ago
|
||
The state of tests on Treeherder right now is very noisy. I looked through the errors and I didn't find anything related, though with so many, it is possible that one slipped through.
Updated•5 years ago
|
Comment 16•5 years ago
|
||
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/9e968a4d00bc update import of Rust SDP parser - r=drno
Comment 17•5 years ago
|
||
Backed out for gtest crashes.
Backout link: https://hg.mozilla.org/integration/autoland/rev/c7c43406bfa941bb846e9861b8b8ed6d1e75df01
Push link: https://hg.mozilla.org/integration/autoland/rev/9e968a4d00bc286fbb4842e9b113f9e264648911
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251105814&repo=autoland&lineNumber=1212
Assignee | ||
Comment 18•5 years ago
|
||
Now passing
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9aeaae18c26c288d734f7de9da0fa73ec4498e42
I also wrote a script to comb the the try failures for anything SDP related.
Comment 19•5 years ago
|
||
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/b6559295ac78 update import of Rust SDP parser - r=drno
Comment 20•5 years ago
|
||
Backed out for bustages on StaticAnalysisFunctions.h
Backout link: https://hg.mozilla.org/integration/autoland/rev/79d08afbec7c8a0030916851dc33c67481dfd294
Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=b6559295ac780cce2b80cd5d493cc3a46b39d0e5&selectedJob=251818893
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251818893&repo=autoland&lineNumber=16626
Assignee | ||
Comment 21•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f54081ad1f883fddb01a4c142c62c947643ce7d
Assignee | ||
Comment 22•5 years ago
|
||
And just to be sure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=148dde1f48e7a54ab5bbfe8ce1fee58884227998
Comment 23•5 years ago
|
||
Pushed by na-g@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/ab06ddac5f0f update import of Rust SDP parser - r=drno
Comment 24•5 years ago
|
||
bugherder |
Assignee | ||
Comment 25•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b49c37b2e8a2e667edb46720e38605538a0e90f5
Assignee | ||
Comment 26•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b60b64e729e969d5a9b9ced6c4d6fb5b35c4a67c
Description
•