Closed Bug 1553014 Opened 6 years ago Closed 6 years ago

Nightly 69 duplicate master password requests after initial bad master password

Categories

(Toolkit :: Password Manager, defect)

69 Branch
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: djndnbvg, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

(Re)started Firefox nightly, either from task bar or to install an update.
I currently have 5 windows and 20 to 30 tabs open.

When the master password request dialog appears, enter an incorrect master password.

I immediately get another for master password request dialog.

After entering part of the 30+ character master password (so a few seconds later), a second master password request dialog appears at the same position and size as the earlier one.

Actual results:

I get two master password request dialogs on screen, the earlier one has a partial master password, and the other is blank or has the next few character from the master password.

This also happened in Nightly 68, but I don't think it happened with earlier releases.

When I encounter this issue, I cancel the later dialog, and reenter the complete master password in the earlier dialog. I have never pressed OK on this later dialog. I have never had a third master password request appear.

Expected results:

Only one master password request dialog should appear, and it should reappear until a correct value is entered or until some limit. A second dialog should never appear while the first is present.

Component: Untriaged → Password Manager
Product: Firefox → Toolkit

If you load about:studies, do you have any enabled? The "hotfix-update-xpi-signing-intermediate…" one causes this and it's a known issue and is being addressed.

Flags: needinfo?(djndnbvg)

In the meantime, disabling that study should fix it.

about:studies shows I have no active studies, and 3 completed studies.


Active studies

Completed studies

  • hotfix-update-xpi-signing-intermediate-bug-v1.0.3-1548973•Complete
  • hotfix-update-xpi-signing-intermediate-bug-1548973•Complete
  • hotfix-reset-xpi-verification-timestamp-1548973•Complete

I don't know how to disable a completed study. I think I saw a way to disable an active study.

Note 2019-05-22 this morning I restarted nightly for an update (green marker on hamburger). I made a typo while entering my master password. I took my time reentering the password, but a second dialog did not appear.

Flags: needinfo?(djndnbvg)

Observation: When I did experience the 2nd dialog, the first request appeared immediately after the restart. Usually several weeks ago, like this morning (after an update), the request for password was not immediately after restart, but some random number of minutes later, or when I went to a site that need a password.

I got the studies disabled yesterday for everyone so that's probably why they are now disabled.

What you observed makes sense… the hotfix study triggered the master password dialog very early whereas the normal behaviour would only trigger it when a login form was encountered or Firefox Sync started to sync (some minutes after startup).

I think we can call this resolved by disabling the studies. Thanks for following-up!

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.