1553018 - Consider supporting [Pref] on dictionary members

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), defect)

Description

[Boris Zbarsky [:bzbarsky]]

We could map it to StaticPrefs, I would think.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Should wait for bug 1550422 to land before adding more static prefs.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1553018 part 1. Add various media preferences bindings use in Pref annotations on interfaces to StaticPrefs. r=jya

The renaming of MediaWebspeechRecognitionEnable to
media_webspeech_recognition_enable is to follow the StaticPrefs convention,
because bindings are going to assume that convention.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1553018 part 2. Make various gfx preferences bindings use in Pref annotations on interfaces follow the StaticPrefs naming convention for getters. r=jya

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1553018 part 3. Add various preferences bindings use in Pref annotations on interfaces to StaticPrefs. r=edgar

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1553018 part 4. Start using StaticPrefs for Pref visibility annotations on interface objects. r=edgar

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1553018 part 5. Remove now-unused conditionSetup bits in getConditionList. r=edgar

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1553018 part 6. Allow [Pref] annotations on dictionary members. r=edgar

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/836cad2f2d0b
part 1.  Add various media preferences bindings use in Pref annotations on interfaces to StaticPrefs.  r=jya
https://hg.mozilla.org/integration/autoland/rev/af355d7ab17e
part 2.  Make various gfx preferences bindings use in Pref annotations on interfaces follow the StaticPrefs naming convention for getters.  r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/e5e66225cfeb
part 3.  Add various preferences bindings use in Pref annotations on interfaces to StaticPrefs.  r=edgar
https://hg.mozilla.org/integration/autoland/rev/337ee3d9fb58
part 4.  Start using StaticPrefs for Pref visibility annotations on interface objects.  r=edgar
https://hg.mozilla.org/integration/autoland/rev/f6affbe72b28
part 5.  Remove now-unused conditionSetup bits in getConditionList.  r=edgar
https://hg.mozilla.org/integration/autoland/rev/293e5868cd10
part 6.  Allow [Pref] annotations on dictionary members.  r=edgar

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/836cad2f2d0b
https://hg.mozilla.org/mozilla-central/rev/af355d7ab17e
https://hg.mozilla.org/mozilla-central/rev/e5e66225cfeb
https://hg.mozilla.org/mozilla-central/rev/337ee3d9fb58
https://hg.mozilla.org/mozilla-central/rev/f6affbe72b28
https://hg.mozilla.org/mozilla-central/rev/293e5868cd10