1553028 - [remote-dbg-next] new about:debugging should be enabled only on Nightly and Dev Edition

Status: RESOLVED FIXED

(DevTools :: about:debugging, task, P1)

Description

[Julian Descottes [:jdescottes]]

It was decided to hold on the release of Remote Debugging until 69, but we would still like users to be able to use remote debugging in Firefox DevEdition in order to connect to Fenix/Firefox preview.

We should update the preference for the new about:debugging to be false on release and beta, true on the other channels.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1553028 - Disable new about:debugging on Beta and Release channels

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38a89c912778
Disable new about:debugging on Beta and Release channels r=daisuke

Comment 3

[Julien Cristau [:jcristau]]

I believe this patch actually disables it on DevEdition as well, because it's built from mozilla-beta and so matches RELEASE_OR_BETA.

You might want "#if defined(MOZ_DEV_EDITION) || defined(NIGHTLY_BUILD)" instead

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/38a89c912778

Comment 5

[Julian Descottes [:jdescottes]]

Thanks for the info, I couldn't test any of that locally.

I ended up pulling from beta, grafting my patch there and checking that it was setting my pref to false but I had no idea how to test this on DevEdition. I'll submit an updated patch with your suggestion.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1553028 - Fix the condition for enabling new aboutdebugging on DevEdition and Nightly

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a57fadeb896
Fix the condition for enabling new aboutdebugging on DevEdition and Nightly r=jcristau

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1a57fadeb896

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: bug1553028-beta.patch

Beta/Release Uplift Approval Request

• User impact if declined: It was decided to hold remote debugging in DevEdition until 69, due to lack of QA resources to perform a final QA sign off in Beta 68. This patch will disable the new remote debugging on Release and Beta.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce:

• open Firefox Beta with a new profile
• go to about:debugging
  With the patch: the old about:debugging should be displayed, ie the sidebar should contain "Add-ons", "Tabs", "Workers"
  Without the patch: the new about:debugging is displayed, ie the sidebar should contain "Setup", "This Firefox" and the devices section with a refresh button.

• List of other uplifts needed: Bug 1553029, Bug 1553031
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple preference change, beta and release will go back to what was set in 67 cycle.
• String changes made/needed:

Comment 10

[Rares Doghi, Desktop QA]

As confusing as this was :)) We can confirm this issue Verified as Fixed in Nightly 69 the preference in about config is TRUE which means we Have Setup, This Firefox and the refresh button as for Beta when the patch will land it should be set to False and the OLD about:debugging will be displayed. I will mark this issue Verified as Fixed in our latest Nightly build 69.0a1 (2019-05-21).

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9066623 [details] [diff] [review]
bug1553028-beta.patch

looks like this uses RELEASE_OR_BETA which isn't what we want

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9066315 [details]
Bug 1553028 - Disable new about:debugging on Beta and Release channels

the patches from central graft cleanly to beta so I'll move the approval flag here.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/b0ba67e4a8a6
https://hg.mozilla.org/releases/mozilla-beta/rev/0c54016947d1