1553039 - default MOZ_GCTIMER output dir to MOZ_UPLOAD_DIR

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P5)

Description

[Steve Fink [:sfink] [:s:]]

If the MOZ_GCTIMER filename is a relative path and MOZ_UPLOAD_DIR is set, resolve MOZ_GCTIMER relative to MOZ_UPLOAD_DIR.

Comment 1

[Steve Fink [:sfink] [:s:]]

Ugh. moz-phab crashed while submitting this. Trying again...

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1553039 - default MOZ_GCTIMER output dir to MOZ_UPLOAD_DIR r=jonco

Comment 3

[Steve Fink [:sfink] [:s:]]

I should mention that the point of this bug is so that you can push to try with --env MOZ_GCTIMER=gc.txt (or --setenv, depending on which command you're using) and you will get a log of GC timing data uploaded as an artifact that you can download for every one of the test jobs.

Comment 4

[Jon Coppeard (:jonco)]

(In reply to Steve Fink [:sfink] [:s:] from comment #3)
This is a great idea.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da42fc59d4fb
default MOZ_GCTIMER output dir to MOZ_UPLOAD_DIR r=jonco

Comment 6

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted&revision=da42fc59d4fb71fd6680b5caf0831e752ca03490

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247580237&repo=autoland&lineNumber=6862

Backout link: https://hg.mozilla.org/integration/autoland/rev/669e1d3cec9bdb7d6385cdb8b7981492d9825410

17:15:17 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/js/src/gc'
17:15:17 INFO - z:/build/build/src/sccache2/sccache.exe z:/build/build/src/clang/bin/clang.exe --driver-mode=cl -m32 -FoUnified_cpp_js_src_gc1.obj -c -DDEBUG=1 -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -Iz:/build/build/src/js/src/gc -Iz:/build/build/src/obj-firefox/js/src/gc -Iz:/build/build/src/obj-firefox/js/src -Iz:/build/build/src/js/src -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -MD -FI z:/build/build/src/obj-firefox/js/src/js-confdefs.h -DMOZILLA_CLIENT -Qunused-arguments -guard:cf -Qunused-arguments -fcrash-diagnostics-dir=z:/build/public/build -TP -nologo -D_CRT_SECURE_NO_WARNINGS -Zc:sizedDealloc- -D_HAS_EXCEPTIONS=0 -guard:cf -W3 -Gy -Zc:inline -arch:SSE2 -Gw -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -GR- -Z7 -Xclang -load -Xclang z:/build/build/src/obj-firefox/build/clang-plugin/clang-plugin.dll -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -WX -Xclang -MP -Xclang -dependency-file -Xclang .deps/Unified_cpp_js_src_gc1.obj.pp -Xclang -MT -Xclang Unified_cpp_js_src_gc1.obj z:/build/build/src/obj-firefox/js/src/gc/Unified_cpp_js_src_gc1.cpp
17:15:17 INFO - In file included from z:/build/build/src/obj-firefox/js/src/gc/Unified_cpp_js_src_gc1.cpp:38:
17:15:17 INFO - z:/build/build/src/js/src/gc/Statistics.cpp(107,15): error: use of undeclared identifier 'PATH_MAX'
17:15:17 INFO - char path[PATH_MAX+1];
17:15:17 INFO - ^
17:15:17 INFO - 1 error generated.
17:15:17 INFO - z:/build/build/src/config/rules.mk:835: recipe for target 'Unified_cpp_js_src_gc1.obj' failed
17:15:17 INFO - mozmake.EXE[4]: *** [Unified_cpp_js_src_gc1.obj] Error 1
17:15:17 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/js/src/gc'
17:15:17 INFO - mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/memory/replace/dmd'
17:15:17 INFO - memory/replace/dmd/Unified_cpp_memory_replace_dmd0.obj
17:15:17 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/memory/replace/dmd'
17:15:17 INFO - z:/build/build/src/config/recurse.mk:74: recipe for target 'js/src/gc/target' failed
17:15:17 INFO - mozmake.EXE[3]: *** [js/src/gc/target] Error 2
17:15:17 INFO - mozmake.EXE[3]: *** Waiting for unfinished jobs....

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/601eed526bef
default MOZ_GCTIMER output dir to MOZ_UPLOAD_DIR r=jonco

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/601eed526bef