1553076 - Checksums for releases don't contain msi, stub installers, or pkg files

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[h11p5g]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0

Actual results:

Cannot find checksums for .msi files on http://ftp.mozilla.org/pub/firefox/releases/67.0/ in SHA256SUMS and SHA512SUMS files.

Comment 1

[Gingerbread Man]

.msi checksums appear to be available only for Nightly, e.g.
https://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central/firefox-69.0a1.en-US.win64.checksums

Comment 2

[Justin Wood (:Callek)]

Preliminary investigation -- they exist in the candidate directory .beet files, .... still to do: more investigation

Comment 3

[Tom Prince [:tomprince]]

It looks like the [.beet files] are the release equivalent of the nightly .checksum files. So those are present in both places. It looks like the generate-checksums doesn't include .msi files, so the aren't included in the summary files.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

In testing adding msi files I noticed we also don't include the windows stub installers or the new mac pkgs.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Bug 1553076 - Checksums for releases don't contain msi, stub installer, or pkg files, r=callek DONTBUILD

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

This doesn't cover snap (eg snap/firefox-68.0.1.snap). That'd be a more involved fix because it appears the .beet is placed in snap/ instead of beetmover-checksums/, and still references target.snap.

Comment 7

[Tom Prince [:tomprince]]

(In reply to Nick Thomas [:nthomas] (UTC+12) from comment #6)

This doesn't cover snap (eg snap/firefox-68.0.1.snap). That'd be a more involved fix because it appears the .beet is placed in snap/ instead of beetmover-checksums/, and still references target.snap.

It'd make sense to add .snap here anyway, so when that get fixed, it will be picked up automatically.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Sure, done. Filed bug 1567337 to fix up beetmover.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f2be9ede5df
Checksums for releases don't contain msi, stub installer, or pkg files, r=Callek DONTBUILD

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0f2be9ede5df

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0660bd1e7f2e96ebb33f8fb2ee7412d150d32f0a
https://hg.mozilla.org/releases/mozilla-release/rev/40e6f8fd0172a0cbfc9ecfdac83bb8282f80c809

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/13fc85d3cf574c3b7fc405f7135b6edcb6e83eb0 (68.1.0esr)
https://hg.mozilla.org/releases/mozilla-esr68/rev/717c697f9d1dcb16f3b3d392cea1ac7aa09b9e00 (60.0.1esr)