1553077 - Port bug 1479538 to thunderbird - [Rewrite callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...)]

Status: RESOLVED FIXED

(Thunderbird :: General, task, P1)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1479538 +++

Rewrite callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...)

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1553077_createElementNS_xul.patch

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9066349 [details] [diff] [review]
bug1553077_createElementNS_xul.patch

Looks OK.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9066349 [details] [diff] [review]
bug1553077_createElementNS_xul.patch

I think we want to backport as much of the de-XBL stuff as possible/reasonable.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/55a4d4b9df15
Port [Bug 1479538 - Rewrite callers of document.createElementNS(XUL_NS, ...) to use document.createXULElement(...)]. r=jorgk

Comment 5

[:aceman]

What about e.g. https://searchfox.org/comm-central/source/common/bindings/toolbar.xml#70 ?

Comment 6

[Jorg K (CEST = GMT+2)]

According to the commit message, the second variant was only run on JS files but not XML files.

Comment 7

[Jorg K (CEST = GMT+2)]

There is one more here:
https://searchfox.org/comm-central/rev/3a823d0c0fca436b989c1bef70563741bcbb7228/common/bindings/toolbar.xml#308

Maybe the file is on the de-XBL hit list, so there's not point to change it?

I'm not sure, but there are also XUL_NS occurrences:
EDITED search:
https://searchfox.org/comm-central/search?q=createElementNS(XUL_NS&case=false&regexp=false&path=

Comment 8

[:aceman]

https://searchfox.org/comm-central/source/mail/components/extensions/ExtensionToolbarButtons.jsm#109

Comment 9

[:aceman]

Yes, I also think those XUL_NS cases should be replaced as they seem to be the same as what is done here. Even comment 0 mentions XUL_NS but in reality only XULNS was replaced by the script.

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: bug1553077_createElementNS_xul_part2.patch

Indeed, there was some cleanup missing

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 9066614 [details] [diff] [review]
bug1553077_createElementNS_xul_part2.patch

Thanks, but you still missed a few multi-line ones in base/content/folderDisplay.js and base/content/tabmail.xml.

EDIT: More precisely, one each in those two files.

Comment 12

[Jorg K (CEST = GMT+2)]

Attachment: bug1553077_createElementNS_xul_part2.patch

I had the files open, so I fixed the two remaining ones.

EDIT: https://bugzilla.mozilla.org/attachment.cgi?oldid=9066614&action=interdiff&newid=9066629&headers=1

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f6a39b92a233
Part 2: more createElementNS(XUL_NS,...) -> createXULElement(...) conversions. r=jorgk DONTBUILD

Comment 14

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/86f96321816478eea37b56c3359f50a27cf7e1a2
https://hg.mozilla.org/releases/comm-beta/rev/7eeeb32bfd07ee54fc5ffc6285fba51aaa3a1888