Closed Bug 1553146 Opened 5 years ago Closed 2 years ago

[meta] Network.dataReceived

Categories

(Remote Protocol :: CDP, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED INACTIVE

People

(Reporter: ato, Unassigned)

References

()

Details

(Keywords: meta, Whiteboard: [event=Network.dataReceived])

No description provided.
Blocks: puppeteer
Keywords: meta
Whiteboard: [event=Network.dataReceived]

Chrome emits this event, but neither Puppeteer nor the Gutenberg tests rely on it.

No longer blocks: puppeteer, puppeteer-mvp

(In reply to Andreas Tolfsen 「:ato」 from comment #1)

Chrome emits this event, but neither Puppeteer nor the Gutenberg tests rely on it.

Really? Given https://wiki.mozilla.org/Remote/GutenbergCDPUsage#Events it is the top-most emitted event those days.

Flags: needinfo?(ato)

Last I checked the Puppeteer and Gutenberg source codes, this event
is not actually consumed by anything. I believe Puppeteer moved to
use the newer Fetch domain for network interception.

Flags: needinfo?(ato)
Whiteboard: [event=Network.dataReceived] → [event=Network.dataReceived][puppeteer-alpha]

(In reply to Andreas Tolfsen 「:ato」 from comment #3)

Last I checked the Puppeteer and Gutenberg source codes, this event
is not actually consumed by anything. I believe Puppeteer moved to
use the newer Fetch domain for network interception.

I just missed this comment when updating the whiteboard entry. You are right. There is no usage of Network.dataReceived in the Gutenberg e2e tests. As such it shouldn't block the alpha release.

Whiteboard: [event=Network.dataReceived][puppeteer-alpha] → [event=Network.dataReceived]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #4)

(In reply to Andreas Tolfsen 「:ato」 from comment #3)

Last I checked the Puppeteer and Gutenberg source codes, this event
is not actually consumed by anything. I believe Puppeteer moved to
use the newer Fetch domain for network interception.

I just missed this comment when updating the whiteboard entry. You are right. There is no usage of Network.dataReceived in the Gutenberg e2e tests. As such it shouldn't block the alpha release.

During one of our London meetings, we grepped for usage of the Puppeteer "on" method(s) in the e2e tests and found nothing, so based on that there's no explicit reliance on any CDP event in gutenberg tests. There may be more subtle dependencies (perhaps like https://bugzilla.mozilla.org/show_bug.cgi?id=1589784#c1).

More importantly, some Puppeteer functionality depends on CDP events, and those that actually show up during a gutenberg test run are a higher priority than those that don't. That list at https://wiki.mozilla.org/Remote/PuppeteerCDPUsage#In_Wordpress_gutenberg_test_suite

Component: CDP: Network → CDP

The meta keyword is there, the bug doesn't depend on other bugs and there is no activity for 12 months.
:whimboo, maybe it's time to close this bug?

Flags: needinfo?(hskupin)

Sounds like this API is not needed and as such we won't even have to keep it open for related network event work.

Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(hskupin)
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.