1553162 - System check the react i18n built .json files

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: General, enhancement, P2)

Description

[Peter Bengtsson [:peterbe]]

https://github.com/mozilla/kuma/pull/5420 has landed in master.
This news code mandates that you execute make compile-react-i18n at some point before starting the server. That creates files like {BASE_DIR}/static/jsi18n/{locale}/react.json. If they don't exist or are corrupt you would get runtime errors in Django.

What we should do is assert, using the Django system checks framework, that all these files exist and are in working condition.

This bug is also about making sure that running system checks are in place in the deploy pipeline so that we don't proceed with the deployment if the system checks fail in any way.

Comment 1

[Peter Bengtsson [:peterbe]]

PR here https://github.com/mozilla/kuma/pull/5425

Comment 2

[Peter Bengtsson [:peterbe]]

Note-to-self; I think the PR is nearly there but there are some decisions we need to make about how we trigger this in Jenkins. See https://github.com/mozilla/kuma/pull/5425#issuecomment-494419034

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub master push: https://github.com/mdn/kuma/commit/fba40fd7813bd95343718e3e809ae17a37630dd3

Commit merged into master by GitHub
Authored by Peter Bengtsson (peterbe)

Comment 4

[BMO Automation]

MDN Web Docs' bug reporting has now moved to GitHub. From now on, please file content bugs at https://github.com/mdn/sprints/issues/ and platform bugs at https://github.com/mdn/kuma/issues/.