Closed Bug 1553176 Opened 5 years ago Closed 5 years ago

Fluent should localize content inside of shadow DOM

Categories

(Core :: Internationalization, defect, P1)

defect

Tracking

()

RESOLVED INVALID

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 obsolete file)

connectRoot right now does not connect shadowRoots, and thus localized strings have to be forwarded into their shadowDOM via propagating attribute changes on the host element.

Flags: qe-verify-
Blocks: 1551472
No longer blocks: about-logins

Seems the simplest fix here may be to add <link rel=localization> elements to the templates, then per emilio, "change aDocument here for the composed document, https://searchfox.org/mozilla-central/rev/89235894292ac4ab4bd7dac44bc60c2e051905f4/dom/html/HTMLLinkElement.cpp#141 and ensuring UnbindFromTree does something sane about it as well of course"

Component: Localization → Internationalization
Depends on: 1555947
Assignee: nobody → jaws
Status: NEW → ASSIGNED

Jared - some parts of your patch will be covered by bug 1560061 which is pretty small and I expect it to land sooner.

Bug 1560061 handles this sufficiently so I've stopped work here.

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Attachment #9072903 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: