155318 - Row goes 3D without being told so

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[moz]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Windows 2000; en-US; rv:1.0.0) Gecko/20020530
BuildID:    2002053012



Reproducible: Always
(at least in windows)

Steps to Reproduce:
1. Open attachment 1 [details] [diff] [review]. It is a normal table
2. Open attachment 2 [details] [diff] [review], the first row has gone 3D style! why? and we only have changed the color of the first row.

If it is useful, I have send an attachment 3 [details] [diff] [review], it is the first case but with a coloured cell. It hasn't gone 3D, ok.

Comment 1

[moz]

Attachment: attachment 1 - initial case

Comment 2

[moz]

Attachment: undesired 3d effect

Comment 3

[moz]

Attachment: Correct behaviour, but for a single cell

Comment 4

[moz]

This bugzilla has created automatically links from my previous words in the bug description, don't pay attention to those, as my attachments are only those in the standard attachment table above.

Comment 5

[Amarendra Hanumanula]

I dont see any kind of 3D effect with the recent builds: 2002070108 branch 
builds on WIN2K. Reporter can you down load the recent builds and try again. I 
dont see any problem with the attached testcases. Please free to reopen if you 
think that the recent builds still breaks.

Comment 6

[moz]

Dear Sir:

I have updated to the latest Mozilla and I see the same 3D effect. Let's see, if you look at the right and the lower border of the yellow cells of the "undesired 3d effect" attachments, you see they are light yellow (almost white); and the upper and left border of those cells are black (almost).   You can grab the screen and zoom at it if you want to see it more clearly

This is the undesired 3D effect brought only because of a color change of the row.

Thank you for your attention 

Comment 7

[moz]

Attachment: Zoom of the undesired 3D effect

Comment 8

[Jo Hermans]

confirmed this with build 20021408 (Mozilla 1.1b) on Mac OS 9

I have seen this effect too, but I never realised it was wrong. The yellow cells
have a darker top and left, and a lighter bottom and right. I agree this is
nice, but it's not what the author intended. It only happens in a TR, not in a TD.

Comment 9

[Amarendra Hanumanula]

confirmed with the latest trunk build: 2002-10-29-08-trunk. Couldnt notice 3d
effects earlier. I was able to see these 3d effets on WINXP. The bottom and
right borders of a cell are lighter than top and left borders. 

Comment 10

[karnaze (gone)]

mass reassign to default owner

Comment 11

[Boris Zbarsky [:bzbarsky]]

This works for me on Mac.  Is this still an issue?

Comment 12

[Erik Fabert]

(In reply to comment #11)
> This works for me on Mac.  Is this still an issue?

Yes, the latest Firefox trunk nightly under Win XP still displays the "undesired 3d effect" attachment exactly the same as the screenshot in attachment 89984 [details].

Comment 13

[Boris Zbarsky [:bzbarsky]]

Oh.  That.  That's because the cells have an inset border, like they're supposed to.

Comment 14

[moz]

If you read the bug description, you see that the bug was that the first row had gone 3D style just because a change the color of the first row.

Nowadays this seems to be "solved"... going 3D always, it does not matter if the user wanted this or not.

> That's because the cells have an inset border, like they're supposed to.
No, the cells don't have an insert border. Look at the source code, no insert border, not 3D effect. Another thing is that some programmers put inset borders (it does not matter if the user wanted it or not).

Comment 15

[Boris Zbarsky [:bzbarsky]]

> Look at the source code

The source code is not the only source of styling.  Look at the UA stylesheet (including the C++ parts) -- the "border" attribute produces inset borders by default.  This becomes very clear if you use border="20" or something along those lines.

Comment 16

[moz]

Before talking more about this, I have to say that I've seen that the bug is not resolved.

EASY VIEW OF THE BUG

If you open the third attachment ( https://bugzilla.mozilla.org/attachment.cgi?id=89895 ), you will see two dark lines between "start" and "14-Dec-2001".

If you open the second attachment 
( https://bugzilla.mozilla.org/attachment.cgi?id=89894 ), you will see only one dark line between "start" and "14-Dec-2001".
_________________________________________________________________________

There is an inconsistency there, something is not working properly. 

The row changed its color and had side effects like you can see.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Ah, I see.  This happens in quirks mode, but not standards mode.  The reason the quirks behavior is the way it is is that the row background is painted over the whole height of the row (including cell borders), not just inside the cells.  This is needed or compat with real-life sites.  If you put a strict doctype, or a transitional doctype with the DTD URI (to trigger standards mode) on your document, you will see the difference.

So this is probably a wontfix, but bernd and fantasai know more about table background painting than I...

Comment 18

[fantasai]

hehe, actually, this has nothing to do with the background getting a 3D effect: it's the inset border (-moz-bg-inset) on the TD picking up the background color of the row. It should be fixed by the patch pending sr in bug 84307. :)

Comment 19

[fantasai]

This should be fixed per dbaron's checkin for bug 84307. Reporter, can you download a nightly build off the Gecko 1.9 / Firefox 3 trunk and confirm?

Comment 20

[moz]

Dear Fantasai, with today's nightly build ("Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a2pre) Gecko/20070205 Minefield/3.0a2pre", that's what it told me), the inset border of the TD works correctly in my examples.

Almost 5 years after the bug was reported, I want to thank you for solving the bug. 

Really, thank you Fantasai, dbaron and you all.