1553185 - Extend Tab Spinner telemetry probes because they expire when Gecko reaches Version 70 on 2019-07-08

Status: VERIFIED FIXED

(Data Platform and Tools :: General, defect)

Description

[Razvan Maries]

Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&revision=1a7d27e9716b885fa3e1a697d896781f76d0c6fb&selectedJob=247547676&searchStr=macosx1010-64-shippable%2Copt%2Cmochitests%2Ctest-macosx1010-64-shippable%2Fopt-mochitest-browser-chrome-e10s-4%2Cm%28bc4%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247547676&repo=try&lineNumber=2796

13:35:37 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_tabSpinnerProbe.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_tabSpinnerProbe.js:78 - TypeError: snapshot is undefined

+++ This bug was initially created as a clone of Bug #1476071 +++

I'm not certain I'm filing this in the right place, but here goes.

I have a dashboard hosted at http://mikeconley.github.io/bug1310250 that graphs tab switch spinner statistics from our Nightly population.

That graph is fed by a JSON file hosted at https://s3-us-west-2.amazonaws.com/telemetry-public-analysis-2/spinner-severity-generator/data/severities_by_build_id_nightly.json.

I believe that JSON file is updated by this "ETL" job:

https://github.com/mozilla/python_mozetl/tree/master/mozetl/tab_spinner

So, assuming all of that is true, I guess the ETL job isn't updating the JSON file anymore - at least, not the JSON file that the dashboard is reading from.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Data review request

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1553185 - Bump the expiry of some Telemetry probes for tab switch performance. data-review=mmccorquodale,r?dthayer

Comment 3

[Chris H-C :chutten]

Comment on attachment 9068843 [details]
Data review request

Redirecting to megan to share the fun.

Comment 4

[Megan McCorquodale]

Comment on attachment 9068843 [details]
Data review request

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

This will be documented in the probe dictionary. 

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is through telemetry and can be turned off through Firefox preferences. 

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Not permanent data collection, but :mconley: to monitor the data. 

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, interaction data. 

    Is the data collection request for default-on or default-off?

Default-on.

    Does the instrumentation include the addition of any new identifiers?

No new identifiers.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Will check in in 6 months.

---
Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42622b5a7b59
Bump the expiry of some Telemetry probes for tab switch performance. data-review=mmccorquodale,r=dthayer

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/42622b5a7b59

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed by latest version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=b18f0867fe28ed0b62789869e614fdccbb7965f8