Status

task
P3
normal
RESOLVED FIXED
Last month
Last month

People

(Reporter: rcaliman, Assigned: rcaliman)

Tracking

unspecified
Firefox 69

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

Last month

Miscellaneous maintenance in CssLogic and associated files:

  • remove obsolete code
  • fix comments
Assignee

Comment 1

Last month

isInherited is a callback function that checks if a given CSS property is inherited. It is misleadingly commented as a cache of inherited properties (which perhaps it is on the InspectorUtils implementation, but on the consumer side it is just a function).

The actual call is done by InspectorUtils.isPropertyInherited. There is no need to pass the handler to CssLogic or to CssPropertyInfo since InspectorUtils is available in the same context as the definition of the consumers.

There is no other use case where a custom handler is passed to check for inherited properties in so it is safe to remove this as an argument and just use InspectorUtils.isPropertyInherited where needed. This cleans up the code slightly.

Assignee

Comment 2

Last month

Depends on D32016
The code comment is perhaps a leftover from a file duplication to extract shared methods to shared/inspector/css-logic.js from server/actors/inspector/css-logic.js.

The comment is confusing because there is no usage of any of the CssLogic terminology within the file.

Comment 4

Last month
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e24c48157bf1
Remove unnecessary isInherited from CssLogic constructor. r=pbro
https://hg.mozilla.org/integration/autoland/rev/e61c315b780d
Remove unrelated code comment from shared/css-logic.js r=pbro

Comment 5

Last month
bugherder
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.