1553194 - CssLogic Maintenance

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Razvan Caliman [:rcaliman]]

Miscellaneous maintenance in CssLogic and associated files:

• remove obsolete code
• fix comments

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1553194 - Remove unnecessary isInherited from CssLogic constructor. r=pbro

isInherited is a callback function that checks if a given CSS property is inherited. It is misleadingly commented as a cache of inherited properties (which perhaps it is on the InspectorUtils implementation, but on the consumer side it is just a function).

The actual call is done by InspectorUtils.isPropertyInherited. There is no need to pass the handler to CssLogic or to CssPropertyInfo since InspectorUtils is available in the same context as the definition of the consumers.

There is no other use case where a custom handler is passed to check for inherited properties in so it is safe to remove this as an argument and just use InspectorUtils.isPropertyInherited where needed. This cleans up the code slightly.

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1553194 - Remove unrelated code comment from shared/css-logic.js r=pbro

Depends on D32016
The code comment is perhaps a leftover from a file duplication to extract shared methods to shared/inspector/css-logic.js from server/actors/inspector/css-logic.js.

The comment is confusing because there is no usage of any of the CssLogic terminology within the file.

Comment 3

[Razvan Caliman [:rcaliman]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=da80854a4d33cfa3efe6c4ae1fec8b8d916978fa

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e24c48157bf1
Remove unnecessary isInherited from CssLogic constructor. r=pbro
https://hg.mozilla.org/integration/autoland/rev/e61c315b780d
Remove unrelated code comment from shared/css-logic.js r=pbro

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e24c48157bf1
https://hg.mozilla.org/mozilla-central/rev/e61c315b780d