1553200 - Fix nsIWebProgressListeners registered on RemoteWebProgressManager with missing event handlers

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, enhancement)

Description

[Beth Rennie [:beth] (she/her)]

Bug 1547806 mentioned running into the following error in the browser console:

RemoteWebProgress failed to call onStatusChange: [Exception... "JavaScript component does not have a method named: "onStatusChange"'JavaScript component does not have a method named: "onStatusChange"' when calling method: [nsIWebProgressListener::onStatusChange]" nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)" location: "JS frame :: resource://gre/modules/RemoteWebProgress.jsm :: _callProgressListeners :: line 103" data: no]

This error is handled gracefully but ideally we should be registering our nsIWebProgressListeners with the correct flags so that this error is not hit.

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1553200 - Specify flags for nsIWebProgress listener in sync TabTracker r?markh

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1553200 - Do not receive unwanted nsIWebProgress events in addon discovery view r?mconley

Depends on D33996

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1553200 - Do not request onRefreshAttempted notifications in XULBrowserWindow r?mconley

Depends on D33997

Comment 4

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1553200 - Specify nsIWebProgress notification flags for nsLDBBrowserContentListener r?dbaron

Depends on D33998

Comment 5

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1553200 - Only request OnStateChange notifications in chrome.identity API r?kmag

Depends on D33999

Comment 6

[Beth Rennie [:beth] (she/her)]

I think all other usages were cleaned up as part of other bugs as the only remaining usage of addProgressListener without a flag are on gBrowser.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/910ee59da71c
Do not receive unwanted nsIWebProgress events in addon discovery view r=mconley

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/910ee59da71c