Closed Bug 1553209 Opened 7 months ago Closed 6 months ago

Logins that lack a username show a LoginListItem with only the hostname

Categories

(Toolkit :: Password Manager, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox69 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(4 files)

In about:logins, logins that lack usernames appear as just the hostname in the list of logins and the height of the item is shorter than the other items.

We should show some default text like "No username" in italics or just show a blank line where the username would have been.

Flags: qe-verify+
Assignee: nobody → jaws
Status: NEW → ASSIGNED

The separation didn't work out right and some work started getting duplicated between login-item and modal-input.

Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e72ce30a625
Merge the modal-input custom element into the login-item custom element. r=MattN,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/026e0fb77150
Show '(no username)' as the username for logins that lack a username. r=MattN,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/1bb2f67f8f3f
Show the password with a monospace font so the reveal-checkbox doesn't move when toggling it. r=MattN
https://hg.mozilla.org/integration/autoland/rev/fdd0795fa469
Show the title on login list items instead of the complete origin. r=MattN

Backed out 8 changesets (bug 1556934, bug 1553209) for build bustages at modal-input.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8ac8a1e12af9ecdf0c50e8d1579df23b417c4e7c

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=fdd0795fa469f2401eac8675a200f506ab2dd2d3&selectedJob=251892728

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251892728&repo=autoland&lineNumber=36614

Log snippet:

[task 2019-06-14T14:22:58.910Z] 14:22:58 INFO - package-tests> make[2]: Entering directory '/builds/worker/workspace/build/src/obj-firefox'
[task 2019-06-14T14:22:58.910Z] 14:22:58 INFO - package-tests> /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.process_install_manifest --track install__test_files.track _tests _build_manifests/install/_test_files
[task 2019-06-14T14:22:58.910Z] 14:22:58 ERROR - package-tests> Traceback (most recent call last):
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> "main", fname, loader, pkg_name)
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> exec code in run_globals
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/process_install_manifest.py", line 114, in <module>
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> main(sys.argv[1:])
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/process_install_manifest.py", line 100, in main
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> defines=args.defines)
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/process_install_manifest.py", line 69, in process_manifest
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> remove_empty_directories=remove_empty_directories)
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/copier.py", line 432, in copy
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> copy_results.append((destfile, f.copy(destfile, skip_if_older)))
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/files.py", line 357, in copy
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> raise ErrorMessage('Symlink target path does not exist: %s' % self.path)
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> mozpack.errors.ErrorMessage: Symlink target path does not exist: /builds/worker/workspace/build/src/browser/components/aboutlogins/content/components/modal-input.js
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> Makefile:123: recipe for target 'install-test-files' failed
[task 2019-06-14T14:22:58.912Z] 14:22:58 ERROR - package-tests> make[2]: *** [install-test-files] Error 1

Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d6554f4587d
Merge the modal-input custom element into the login-item custom element. r=MattN,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/c344c7e495b6
Show '(no username)' as the username for logins that lack a username. r=MattN,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/21497671f428
Show the password with a monospace font so the reveal-checkbox doesn't move when toggling it. r=MattN
https://hg.mozilla.org/integration/autoland/rev/aa877d21db8e
Show the title on login list items instead of the complete origin. r=MattN

The feature is not complete and is disabled by pref in Firefox 69. However, I have verified these changes in Firefox 69 RC build on Windows 7 x64, mac 10.14 and Ubuntu 16.04. The changes made works as expected, but since the feature is not complete in Firefox 69 there are a few issues that affect these areas but are fixed and verified in Firefox 70.

Based on this I will remove the "qe-verify+" flag and mark the bug as Verified- Fixed.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.