Closed Bug 1553237 Opened 1 year ago Closed 1 year ago

Simplify nsISearchService.addEngineWithDetails to one signature

Categories

(Firefox :: Search, task, P3)

task

Tracking

()

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: standard8, Assigned: sapoliakaran)

References

Details

Attachments

(1 file, 1 obsolete file)

nsISearchService.addEngineWithDetails currently supports two formats of parameters:

Services.search.addEngineWithDetails(name, iconURL, alias, description, method, template, extensionID);

or

Services.search.addEngineWithDetails(name, details);

We want to migrate to using just the name, details form, and simplify the API. Bug 1553236 is changing the tests, this bug should do the API itself, as well as any final callers (e.g. android).

https://searchfox.org/mozilla-central/search?q=addEngineWithDetails&case=false&regexp=false

Depends on: 1556804

Hello Mark,
I would like to continue working on simplifying the API. May I take up this one?

Sure.

Assignee: nobody → sapoliakaran
Status: NEW → ASSIGNED
Attachment #9071593 - Attachment is obsolete: true
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45ab583f7acb
Simplify nsISearchService.addEngineWithDetails to one signature. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in before you can comment on or make changes to this bug.