1553273 - Perma-failing TelemetryGeckoViewFixture.TimerHitCountProbe | Value of: value.isInt32() when the Gecko version number is bumped to 70 on 2019-07-08

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:

+++ This bug was initially created as a clone of Bug #1488958 +++

Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=1a7d27e9716b885fa3e1a697d896781f76d0c6fb&selectedJob=247547695

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247547695&repo=try

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Please also check if this coves all other failures mentioned in https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=1a7d27e9716b885fa3e1a697d896781f76d0c6fb&searchStr=gtest&selectedJob=247548522 (ignore the first line).

Comment 2

[Alessio Placitelli [:Dexter]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #1)

Please also check if this coves all other failures mentioned in https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=1a7d27e9716b885fa3e1a697d896781f76d0c6fb&searchStr=gtest&selectedJob=247548522 (ignore the first line).

Yes, it seems to cover it. It's due to the related metric being expired. Clearing ni? so that it shows up in our triage.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

What has been decided in the triage mentioned in comment 2?

Comment 4

[Alessio Placitelli [:Dexter]]

Hey Chris,

these are from the expired GeckoView persistence timers probes. Should we renew or remove them? Given that the one time we looked at the data we didn't find it too useful, and that we're changing the GeckoView approach with Glean, I don't think there's value in renewing them.

Thoughts?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a6887d6fc31
Disable TelemetryGeckoViewFixture.TimerHitCountProbe until decision about telemetry probe has been made. a=permafail

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/7b346e25734f
Disable TelemetryGeckoViewFixture.TimerHitCountProbe until decision about telemetry probe has been made. a=permafail

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7b346e25734f

Comment 8

[Chris H-C :chutten]

(In reply to Alessio Placitelli [:Dexter] from comment #4)

Hey Chris,

these are from the expired GeckoView persistence timers probes. Should we renew or remove them? Given that the one time we looked at the data we didn't find it too useful, and that we're changing the GeckoView approach with Glean, I don't think there's value in renewing them.

Thoughts?

Agreed. Let's pull them out.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/b38eb112eb03
Disable TelemetryGeckoViewFixture.PendingOperationsHighWater until decision about telemetry probe has been made. a=permafail

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8a6887d6fc31

Comment 11

[Chris H-C :chutten]

Scrubbing priority so it'll show in triage

Comment 12

[Jan-Erik Rediger [:janerik]]

Currently wrangling around in that code anyway, I'll just scrub this from you.

Comment 13

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1553273 - Remove expired timer hit count probe

Depends on D37535

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Can you also take care of PendingOperationsHighWater (see comment 9), please?

Comment 15

[Jan-Erik Rediger [:janerik]]

Taken care of in bug 1564628 and included in the same review (so it both lands together)

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38dc35fe053f
Remove expired timer hit count probe r=chutten

Comment 17

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/38dc35fe053f