1553286 - Mark legacycall hooks as MOZ_CAN_RUN_SCRIPT

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1553286. Mark legacycall hooks (and a few other binding hooks) as MOZ_CAN_RUN_SCRIPT. r=mccr8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5ce5a80aa79
Mark legacycall hooks (and a few other binding hooks) as MOZ_CAN_RUN_SCRIPT.  r=mccr8

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d5ce5a80aa79

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 9066529 [details]
Bug 1553286. Mark legacycall hooks (and a few other binding hooks) as MOZ_CAN_RUN_SCRIPT. r=mccr8

Beta/Release Uplift Approval Request

• User impact if declined: Can't land the fix for bug 1551282.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just adding annotations to some function to make static analysis happy. There should be no runtime behavior change here.
• String changes made/needed:

Comment 5

[Julien Cristau [:jcristau]]

Comment on attachment 9066529 [details]
Bug 1553286. Mark legacycall hooks (and a few other binding hooks) as MOZ_CAN_RUN_SCRIPT. r=mccr8

prerequisite for bug 1551282; approved for 68.0b5

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/77f31bca1162

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 9066529 [details]
Bug 1553286. Mark legacycall hooks (and a few other binding hooks) as MOZ_CAN_RUN_SCRIPT. r=mccr8

Looks like we won't need this for bug 1551282.