4:4:4 RGB AV1 video plays back in wrong colors
Categories
(Core :: Audio/Video: Playback, enhancement, P3)
Tracking
()
People
(Reporter: TD-Linux, Assigned: TD-Linux)
References
(Blocks 1 open bug)
Details
Attachments
(6 files)
The attached webm file displays with wrong colors - the file is tagged as a RGB video, but decoded as if it was YUV.
Comment 1•5 years ago
|
||
Hi, Matt,
Would you mind to take a look at this issue?
Comment 2•5 years ago
|
||
Probably best for jya to find someone to work on this.
Comment 3•5 years ago
|
||
That's not just the wrong colorspace, that's RGB being displayed as yuv.
We have no code to handle non YUV images.
Delegating to :achronop as he integrated the dav1d decoder.
Comment 4•5 years ago
|
||
This is the summary from the discussion in IRC:
Two options here. First option is to create a new colorspace that will carry out the YUV to RGB conversion in the shaders which can be a simple copy. A similar job has been done in Bug 1493898 for supporting BT2020 colorspace. This requires modifying all the compositors.
The second option, is to create a RGBA image, in the decoder, instead of a YUV image. That will avoid the extra copy. We do something similar to support alpha channels in the VPX Decoder [1]. That is simpler but we need to create IPDL support for passing RGB images between RDD and content process which means extra IPC handling.
Updated•5 years ago
|
Assignee | ||
Comment 5•4 years ago
|
||
Assignee | ||
Comment 6•4 years ago
|
||
Assignee | ||
Comment 7•4 years ago
|
||
Assignee | ||
Comment 8•4 years ago
|
||
Depends on D85959
Assignee | ||
Comment 9•4 years ago
|
||
Depends on D85960
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Pushed by tdaede@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fe54954b8b8d Add YUVColorSpace::Identity. r=jgilbert https://hg.mozilla.org/integration/autoland/rev/825850a49a4f Add YUVColorSpace::Identity decoding to AVIF. r=jbauman https://hg.mozilla.org/integration/autoland/rev/be342c90755d Add identity conversion to ConvertYCbCrToRGB32. r=jgilbert
Comment 11•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fe54954b8b8d
https://hg.mozilla.org/mozilla-central/rev/825850a49a4f
https://hg.mozilla.org/mozilla-central/rev/be342c90755d
Comment 12•4 years ago
|
||
(In reply to Thomas Daede [:TD-Linux] from comment #0)
Created attachment 9066531 [details]
zmwz.webmThe attached webm file displays with wrong colors - the file is tagged as a RGB video, but decoded as if it was YUV.
This video would still play with the wrong colour following this change ; as it only modified the AVIF decoder.
Updated•4 years ago
|
Description
•