Closed Bug 1553297 Opened 8 months ago Closed 7 months ago

Perma test_ext_storage_idb_data_migration.js | test_storage_local_data_migration - [test_storage_local_data_migration : 69] Got parent telemetry events in the snapshot - "undefined" == true when gecko version increases to 70 on 2019-07-08

Categories

(WebExtensions :: General, defect, P2)

defect

Tracking

(firefox-esr60 unaffected, firefox67 unaffected, firefox67.0.1 unaffected, firefox68 unaffected, firefox69+ verified)

VERIFIED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox67.0.1 --- unaffected
firefox68 --- unaffected
firefox69 + verified

People

(Reporter: aryx, Assigned: rpl)

Details

Attachments

(2 files)

Version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=1a7d27e9716b885fa3e1a697d896781f76d0c6fb&selectedJob=247558896

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=247558896&repo=try

14:43:49 INFO - TEST-PASS | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js | test_storage_local_data_migration - [test_storage_local_data_migration : 62] Got the expected count on category "failure" for histogram WEBEXT_STORAGE_LOCAL_IDB_MIGRATE_RESULT_COUNT - 0 == 0
14:43:49 WARNING - TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js | test_storage_local_data_migration - [test_storage_local_data_migration : 69] Got parent telemetry events in the snapshot - "undefined" == true
14:43:49 INFO - Z:/task_1558443987/build/tests/xpcshell/tests/toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js:assertTelemetryEvents:69
14:43:49 INFO - Z:/task_1558443987/build/tests/xpcshell/tests/toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js:test_storage_local_data_migration:176
14:43:49 INFO - exiting test
14:43:49 INFO - Unexpected exception NS_ERROR_ABORT:
14:43:49 INFO - _abort_failed_test@Z:\task_1558443987\build\tests\xpcshell\head.js:742:20
14:43:49 INFO - do_report_result@Z:\task_1558443987\build\tests\xpcshell\head.js:849:5
14:43:49 INFO - Assert<@Z:\task_1558443987\build\tests\xpcshell\head.js:57:5
14:43:49 INFO - proto.report@resource://testing-common/Assert.jsm:213:10
14:43:49 INFO - proto.ok@resource://testing-common/Assert.jsm:233:10
14:43:49 INFO - assertTelemetryEvents@Z:/task_1558443987/build/tests/xpcshell/tests/toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js:69:3
14:43:49 INFO - test_storage_local_data_migration@Z:/task_1558443987/build/tests/xpcshell/tests/toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js:176:3
14:43:49 INFO - async*run_next_test/_run_next_test/<@Z:\task_1558443987\build\tests\xpcshell\head.js:1437:22
14:43:49 INFO - _run_next_test@Z:\task_1558443987\build\tests\xpcshell\head.js:1437:38
14:43:49 INFO - run@Z:\task_1558443987\build\tests\xpcshell\head.js:688:9
14:43:49 INFO - _do_main@Z:\task_1558443987\build\tests\xpcshell\head.js:227:6
14:43:49 INFO - _execute_test@Z:\task_1558443987\build\tests\xpcshell\head.js:529:5
14:43:49 INFO - @-e:1:1
14:43:49 INFO - exiting test

WEBEXT_STORAGE_LOCAL_IDB_MIGRATE_RESULT_COUNT expires in 72, shouldn't be that: https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/toolkit/components/telemetry/Histograms.json#14104

Flags: needinfo?(lgreco)

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #0)

...
14:43:49 WARNING - TEST-UNEXPECTED-FAIL | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_storage_idb_data_migration.js | test_storage_local_data_migration - [test_storage_local_data_migration : 69] Got parent telemetry events in the snapshot - "undefined" == true
...
WEBEXT_STORAGE_LOCAL_IDB_MIGRATE_RESULT_COUNT expires in 72, shouldn't be that: https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/toolkit/components/telemetry/Histograms.json#14104

yeah, the histogram expiring version is set to Firefox 72, what is actually failing in this test file is the telemetry event
"extensions.data.migrateResult"
, which is set to expire on Firefox 70.

Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Flags: needinfo?(lgreco)
Priority: -- → P2

Hi Chris,
I've just attached a new data review request related to the renewal of the extensions.data.migrateResult telemetry event.

Attachment #9070931 - Flags: data-review?(chutten)
Comment on attachment 9070931 [details]
request-data-review-bug-1553297-renew-storage-data-migration-event.md

Load balancing to Megan.
Attachment #9070931 - Flags: data-review?(chutten) → data-review?(mmccorquodale)

Hi Megan,
is there anything I can do to help the data review request to move forward?
(e.g. providing any additional information that may help you to evaluate it).

(the attached patch is already approved, the only thing missing to land it should be the data review request).

Flags: needinfo?(mmccorquodale)
Comment on attachment 9070931 [details]
request-data-review-bug-1553297-renew-storage-data-migration-event.md

1.  Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way? 
Documentation will be in the probe dictionary. 


2.  Is there a control mechanism that allows the user to turn the data collection on and off?  
Can be turned off by opting out of telemetry collection. 

3.  If the request is for permanent data collection, is there someone who will monitor the data over time?
Not permanent data collection. 

4.  Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Category 1, Technical Data

5.  Is the data collection request for default-on or default-off?
Default on. 

6.  Does the instrumentation include the addition of any new identifiers?
No new identifiers.


7.   Is the data collection covered by the existing Firefox privacy notice? 
Yes.


8.  Does there need to be a check-in in the future to determine whether to renew the data?
Yes, check in required at version 73. 

9.  Does the data collection use a third-party collection tool?
No.
Flags: needinfo?(mmccorquodale)
Attachment #9070931 - Flags: data-review?(mmccorquodale) → data-review+
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/a10e5298d3e2
Re-new extension.data.migrateResult telemetry event. r=janerik
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.