1553304 - Use APZC for accessibility scroll action on root node

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

The message dispatched to Gecko is only listened for when touch exploration is enabled (eg. TalkBack). Other, non touch-exploration services need to be able to scroll the root window, specifically Switch Access.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1553304 - Use APZC for accessibility scroll action on root node. r?#geckoview-reviewers!

Comment 2

[Eitan Isaacson [:eeejay]]

Looks like Chromium tries to scroll by 80%, we should do the same.

https://cs.chromium.org/chromium/src/content/browser/accessibility/browser_accessibility_android.cc?l=1232&rcl=7a2b7086f54cb4d6d7ec05a1a1f8a839de9c65a2

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4646d2e361f6
Use APZC for accessibility scroll action on root node. r=geckoview-reviewers,snorp

Comment 4

[Eitan Isaacson [:eeejay]]

Blocked Fenix issue: https://github.com/mozilla-mobile/fenix/issues/1712

Comment 5

[Chris Peterson [:cpeterson]]

If you'd like this bug fixed in Fenix MVP, we'll need to uplift your fix to GV 68 Beta.

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4646d2e361f6

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 9066548 [details]
Bug 1553304 - Use APZC for accessibility scroll action on root node. r?#geckoview-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Switch Access users won't be able to scroll
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a minor change that shouldn't affect anyone who is not using TalkBack or Switch Access.
• String changes made/needed:

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Is there any risk of this affecting fennec?

Comment 9

[Eitan Isaacson [:eeejay]]

(In reply to Julien Cristau [:jcristau] from comment #8)

Is there any risk of this affecting fennec?

No, I verified that this works on Fennec too.

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9066548 [details]
Bug 1553304 - Use APZC for accessibility scroll action on root node. r?#geckoview-reviewers!

android a11y fix for beta68

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5e00311d1ebd