Closed Bug 1553304 Opened 7 months ago Closed 7 months ago

Use APZC for accessibility scroll action on root node

Categories

(GeckoView :: General, defect, P1)

Unspecified
Android
defect

Tracking

(firefox67 wontfix, firefox68 fixed, firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox67 --- wontfix
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

(Whiteboard: [geckoview:fenix:m7])

Attachments

(1 file)

The message dispatched to Gecko is only listened for when touch exploration is enabled (eg. TalkBack). Other, non touch-exploration services need to be able to scroll the root window, specifically Switch Access.

Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4646d2e361f6
Use APZC for accessibility scroll action on root node. r=geckoview-reviewers,snorp

If you'd like this bug fixed in Fenix MVP, we'll need to uplift your fix to GV 68 Beta.

Assignee: nobody → eitan
Priority: -- → P1
Whiteboard: [geckoview:fenix:m7]
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9066548 [details]
Bug 1553304 - Use APZC for accessibility scroll action on root node. r?#geckoview-reviewers!

Beta/Release Uplift Approval Request

  • User impact if declined: Switch Access users won't be able to scroll
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a minor change that shouldn't affect anyone who is not using TalkBack or Switch Access.
  • String changes made/needed:
Attachment #9066548 - Flags: approval-mozilla-beta?

Is there any risk of this affecting fennec?

Flags: needinfo?(eitan)

(In reply to Julien Cristau [:jcristau] from comment #8)

Is there any risk of this affecting fennec?

No, I verified that this works on Fennec too.

Flags: needinfo?(eitan)

Comment on attachment 9066548 [details]
Bug 1553304 - Use APZC for accessibility scroll action on root node. r?#geckoview-reviewers!

android a11y fix for beta68

Attachment #9066548 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.