1553387 - 'Window' menu mostly empty (missing the list of windows) since switching to browser.xhtml

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[:glob ✱]

69.0a1 (2019-05-21) (64-bit) macOS

A change in recent nightly builds has resulted in a mostly empty 'Window' menu - just Minimise and Zoom, no actual windows are listed.

mozregression narrowed it down to https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5a721a7648f2db40785729ed8fc7c7444c1afcaf&tochange=ad38bcbe7879cf715df2a49840b62d1235689882 - bug 1534407

Comment 1

[Brian Grinstead [:bgrins]]

This is a createElement -> createXULElement call we missed in Bug 1551320: https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/toolkit/content/macWindowMenu.js#13. Updating that fixes the menu, but I'm going to do a try push with the assertion at https://bugzilla.mozilla.org/show_bug.cgi?id=1551320#c18 & browser.xul turned back on to make sure we didn't miss anything else.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Bug 1553387 - Use createXULElement for 'window' menuitems on osx

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #1)

This is a createElement -> createXULElement call we missed in Bug 1551320: https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/toolkit/content/macWindowMenu.js#13.

This was probably missed because this code isn't triggered by any tests, as far as I can tell. Going to fix that in the patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd05a7d4bd38
Use createXULElement for 'window' menuitems on osx r=Gijs

Comment 5

[Alexandru Michis [:malexandru]]

Backed out changeset dd05a7d4bd38 for browser-chrome failures at browser_window_menu_list.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a145dd581ae649f9bb5a34aa429d358aa7949b9f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=dd05a7d4bd38f2d9911e355ac1fdd9ec80a75829&selectedJob=247899353

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247899353&repo=autoland&lineNumber=961

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfabf5135cf1
Use createXULElement for 'window' menuitems on osx r=Gijs

Comment 7

[Brian Grinstead [:bgrins]]

Oops, I updated to address Gijs' comments and had a good try push, but I hadn't stepped through the Submit to Phabricator (YES/No/Always) prompt in the terminal before using lando (so phab didn't have the latest version).

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/dfabf5135cf1