1553400 - XMLHttpRequestDoneNotifier should own XHR, not vice-versa

Status: RESOLVED FIXED

(Core :: DOM: Networking, defect, P1)

Description

[Olli Pettay [:smaug][[e-mail]]]

If GC/CC run, what keeps XHR alive long enough.

oops, my bad. Patch coming later today. Trivial fix, safe for beta.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1553400 - XMLHttpRequestDoneNotifier should own XHR, not vice-versa, r=baku

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I tried to write a testcase for this, but failed.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=46a7abc6963220060c1de64321156cf4b2494880

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9066708 [details]
Bug 1553400 - XMLHttpRequestDoneNotifier should own XHR, not vice-versa, r=baku

Beta/Release Uplift Approval Request

• User impact if declined: In theory load event for XMLHttpRequest might not fire. (But I haven't managed to write a testcase)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Right now XHR owns XMLHttpRequestDoneNotifier, the patch makes XMLHttpRequestDoneNotifier to own XHR.
  Explicit raw pointer clearance is still there.
• String changes made/needed: NA

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/688e84498d38
XMLHttpRequestDoneNotifier should own XHR, not vice-versa, r=baku

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/688e84498d38

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9066708 [details]
Bug 1553400 - XMLHttpRequestDoneNotifier should own XHR, not vice-versa, r=baku

approved for 68.0b5

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/22734638bdcb