Closed Bug 1553429 Opened 6 years ago Closed 6 years ago

Properly implement the `*etUploadEnabled` APIs in glean-core

Categories

(Data Platform and Tools :: Glean: SDK, defect, P1)

Product:
Data Platform and Tools
Component:
Glean: SDK
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Dexter, Assigned: janerik)

Details

(Whiteboard: [telemetry:glean-rs:m5])

Due to an API shortcoming, Glean.setUploadEnabled is supposed to be called before the initialize function. Right now, due to 1553424, this crashes the product. However, even if we didn't crash, we would have no handle available yet to use to communicate with the Rust core through the FFI.

This bug is for changing the Glean.setUploadEnabled logic, making it so that the provided value is cached if Glean is not yet initialized, and applied as the first action when an handle is available.

In order to be future proof, we should probably start encoding this call dependency in the Glean init FFI function. We will eventually change the Kotlin side as well.

Priority: -- → P3
Whiteboard: [telemetry:glean-rs:m5]
Assignee: nobody → jrediger
Priority: P3 → P1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.