Closed Bug 1553458 Opened 5 years ago Closed 5 years ago

aboutdebugging-new/src/base.css references undefined var(--in-content-text-color)

Categories

(DevTools :: about:debugging, task, P3)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: robwu, Assigned: MonikaMaheshwari, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

.main-heading has color: var(--in-content-text-color); at https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/devtools/client/aboutdebugging-new/src/base.css#183

This var(--in-content-text-color); should be --text-color , since the common.inc.css file where it is usually defined isn't loaded in the new about:debugging page.

The result can be seen by visiting about:debugging#/runtime/this-firefox and inspecting the header at the right of the Nightly icon. Fortunately this error doesn't cause any issues, because the invalid color is ignored, and the inherited color is var(--text-color), as desired.

(The browser_parsable_css.js test is supposed to catch such errors, but it failed to, because in-content/common.css is loaded before testing whether there are undefined variables in the devtools.)

Thanks for filing!

Let's remove the line completely

color: var(--in-content-text-color);

at https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/devtools/client/aboutdebugging-new/src/base.css#183

The color is already inherited from body { } at https://searchfox.org/mozilla-central/rev/6c9f60f8cc064a1005cd8141ecd526578ae9da7a/devtools/client/aboutdebugging-new/src/base.css#113

Good first bug if anyone wants to get started with the development environment (docs at http://docs.firefox-dev.tools/)

Mentor: jdescottes
Keywords: good-first-bug
Priority: -- → P3

Hi can I work on this issue?

(In reply to Monika Maheshwari [:MonikaMaheshwari] from comment #2)

Hi can I work on this issue?

Thanks! Assigning the bug to you.
My previous comment should still be a good description of what needs to be done, but don't hesitate to ping me with a needinfo (below the comment box) if there's anything you need to get started.

Assignee: nobody → monikamaheshwari1996
Status: NEW → ASSIGNED
Type: defect → task

Hi Monika, are you still interested in working on this bug? If yes and you just need more time, that's fine. If you, however, do not plan on working on it anymore, please do let us know so this bug can be made available to others.

Flags: needinfo?(monikamaheshwari1996)

Hi sorry I forgot to link bug id in my revision :)

Flags: needinfo?(monikamaheshwari1996)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f594a688b3c4
remove in-content-text-color r=remote-debugging-reviewers,daisuke
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: