1553463 - The source editor should use a weak PrefObserver

Status: RESOLVED WONTFIX

(DevTools :: Shared Components, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

This would potentially allow to not have to clear its destroy function when we're closing the toolbox (e.g. from Console's JsTerm).

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1553463 - Use a weak observer in Editor. r=jdescottes.

Depends on D32162

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Since the sourceeditor is a component (and not a panel) that may be removed even if we're not destroying the toolbox, it's probably safer to keep traditional observers that are explicitly removed.