Closed
Bug 1553467
Opened 5 years ago
Closed 5 years ago
[Inactive CSS] Increase the tooltip's visual padding to match the attached mockup.
Categories
(DevTools :: Inspector: Rules, defect, P2)
DevTools
Inspector: Rules
Tracking
(firefox69 verified)
VERIFIED
FIXED
Firefox 69
Tracking | Status | |
---|---|---|
firefox69 | --- | verified |
People
(Reporter: miker, Assigned: miker)
References
(Blocks 1 open bug)
Details
Attachments
(4 files, 1 obsolete file)
Top and padding look good, but the left padding looks too small. I know the padding is the same based on actual pixel numbers and based on the paragraph borders, but I was thinking more about the visual size of the white space.
Could you try the equivalent of 13px for the side paddings?
Comment hidden (obsolete) |
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Attachment #9066699 -
Attachment is obsolete: true
Assignee | ||
Comment 3•5 years ago
|
||
@victoria I just realized there are two tooltips to check... are these better?
Assignee | ||
Updated•5 years ago
|
Attachment #9066690 -
Attachment description: Screenshot 2019-05-22 at 13.56.14.png → Mockup.png
Comment 4•5 years ago
|
||
Comment on attachment 9066699 [details]
Better?
Yes, these paddings look perfect! Thanks so much for the extra detail work.
One last thing - I'm realizing now that the margin between the two paragraphs looks 4px too tall. I think I said somewhere that it should be "1em" but that was wrong. Sorry about this!
Thanks for bearing with me. It will be really nice to have this tooltip styling ready to go for everything else that needs new/updated tooltips!
Flags: needinfo?(victoria)
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b860b13c8eae [Inactive CSS] Increase the tooltip's visual padding to match the attached mockup. r=pbro
Comment 8•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in
before you can comment on or make changes to this bug.
Description
•