stage-cppunittests fails when MOZ_COPY_PDBS is specified

RESOLVED FIXED in Firefox 68

Status

defect
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

Trunk
mozilla69
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox68 fixed, firefox69 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

When MOZ_COPY_PDBS is specified, we build pdbs next to their executables. When PKG_SKIP_STRIP is not specified, we strip the tests.

However we locate the tests using

CPP_UNIT_TEST_BINS=$(wildcard $(DIST)/cppunittests/*)

Which also grabs the pdbs (when MOZ_COPY_PDBS=1).

We need to filter out the pdbs so we don't try to stirp them (which doesn't work, and fails.)

This doesn't affect the Windows ASAN build (which also uses MOZ_COPY_PDBS) because PKG_SKIP_STRIP is specified

Attachment #9066740 - Attachment is obsolete: true
Keywords: checkin-needed

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88cd601e92b7
Filter out pdbs from CPP_UNIT_TEST_BINS so we don't try to strip them r=firefox-build-system-reviewers,dmajor

Keywords: checkin-needed
Blocks: 1471698

Comment on attachment 9066705 [details]
Bug 1553481 - Filter out pdbs from CPP_UNIT_TEST_BINS so we don't try to strip them r?#build

Beta/Release Uplift Approval Request

  • User impact if declined: Required for 1471698, which is updating the mingw-clang compiler so it matches the one Tor will use. So it blocks that one.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only affects the mingw-clang build.
  • String changes made/needed:
Attachment #9066705 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9066705 [details]
Bug 1553481 - Filter out pdbs from CPP_UNIT_TEST_BINS so we don't try to strip them r?#build

fix for mingw-clang build issue, approved for 68.0b4

Attachment #9066705 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.