1553482 - [BinAST] Expose the grammar to tokenizers to support reading Huffman tables

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1553482 - Generating BINAST_TOTAL_NUMBER_OF_FIELDS, BINAST_NUMBER_OF_LIST_TYPES;r?arai

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1553482 - Generating BinASTInterfaceAndField;r?arai

Depends on D32289

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1553482 - Exposing some of the grammar as macros;r?arai

To extract Huffman tables (see bug 1552435), we need the ability to walk through the grammar.
This patch starts implementing grammar walking, as macros - at this stage, sufficiently to walk
through interfaces and start dealing with their fields.

Depends on D32291

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Bug 1553482 - Use BinASTInterfaceAndField in Context;r?arai

Depends on D32295

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9db8b5eba797
Generating BINAST_TOTAL_NUMBER_OF_FIELDS, BINAST_NUMBER_OF_LIST_TYPES;r=arai
https://hg.mozilla.org/integration/autoland/rev/82f5e463bcb5
Generating BinASTInterfaceAndField;r=arai
https://hg.mozilla.org/integration/autoland/rev/f6e6533c5db2
Exposing some of the grammar as macros;r=arai
https://hg.mozilla.org/integration/autoland/rev/dea9d20a1162
Use BinASTInterfaceAndField in Context;r=arai

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1553482) for causing build bustages in BinASTTokenReaderBase.h CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=dea9d20a1162715140612c9b76bf94fb3c6ce452

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248158375&repo=autoland&lineNumber=3012

https://hg.mozilla.org/integration/autoland/rev/6eb35ce885410120018363f9b3ed0d360c13d2d7

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Thanks, I'll fix this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5570e3e6c5e5
Generating BINAST_TOTAL_NUMBER_OF_FIELDS, BINAST_NUMBER_OF_LIST_TYPES;r=arai
https://hg.mozilla.org/integration/autoland/rev/c50879a48ff8
Generating BinASTInterfaceAndField;r=arai
https://hg.mozilla.org/integration/autoland/rev/57a5c8689ed3
Exposing some of the grammar as macros;r=arai
https://hg.mozilla.org/integration/autoland/rev/49278023aa7d
Use BinASTInterfaceAndField in Context;r=arai

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1553482) for causing build bustages in BinASTTokenReaderBase.h CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=248203453&revision=49278023aa7d33d3ead6ce778dffe69d6e25f04a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248203409&repo=autoland&lineNumber=6259

Backout: https://hg.mozilla.org/integration/autoland/rev/cbb2af10089cfcdd849726f14b84ca5754f9b9fb

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53e0102ec341
Generating BINAST_TOTAL_NUMBER_OF_FIELDS, BINAST_NUMBER_OF_LIST_TYPES;r=arai
https://hg.mozilla.org/integration/autoland/rev/3fe9b49f150c
Generating BinASTInterfaceAndField;r=arai
https://hg.mozilla.org/integration/autoland/rev/9c9cc391abf9
Exposing some of the grammar as macros;r=arai
https://hg.mozilla.org/integration/autoland/rev/f2ac175aed4c
Use BinASTInterfaceAndField in Context;r=arai

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/53e0102ec341
https://hg.mozilla.org/mozilla-central/rev/3fe9b49f150c
https://hg.mozilla.org/mozilla-central/rev/9c9cc391abf9
https://hg.mozilla.org/mozilla-central/rev/f2ac175aed4c