1553487 - ReferenceError: reference to undefined property "matchedList"" {file: "resource://gre/modules/RemoteWebProgress.jsm" line: 186}]

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Seen this locally and in CI when running xpcshell tests at least:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247767972&repo=try&lineNumber=2536

13:49:11 INFO - PID 3069 | JavaScript strict warning: resource://gre/modules/RemoteWebProgress.jsm, line 186: ReferenceError: reference to undefined property "matchedList"
13:49:11 INFO - "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "matchedList"" {file: "resource://gre/modules/RemoteWebProgress.jsm" line: 186}]"

Comment 1

[Drew Willcoxon :adw]

Barret, it looks like you added this line as part of bug 1510569: https://searchfox.org/mozilla-central/rev/7556a400affa9eb99e522d2d17c40689fa23a729/toolkit/modules/RemoteWebProgress.jsm#184

Could you take a look please?

Comment 2

[Beth Rennie [:beth] (she/her)]

I took at the history of the of WebProgressChild.jsm and it seems that WebProgressChild.jsm used to send along matchedList as part of the onSecurityChange event, which got moved into the onContentBlockingEvent, which was eventually removed when it was ported to c++.

This property is no longer ever sent and so this should be updated to never try to retrieve it.

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1553487 - Do not attempt to instantiate RemoteWebProgressRequest with a matched list from JS r?ehsan

The WebProgressChild no longer sends a matchedList parameter in its JSON
messages to the RemoteWebProgress, so it will always be undefined and trigger
a ReferenceError.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c802fa1d388
Do not attempt to instantiate RemoteWebProgressRequest with a matched list from JS r=Ehsan

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7c802fa1d388