1553502 - Compile DOM worker scripts directly from UTF-8, behind a pref

Status: RESOLVED FIXED

(Core :: DOM: Workers, task, P3)

Description

[Jeff Walden [:Waldo]]

Worker scripts are UTF-8 when downloaded, and read from cache they're UTF-8 as well, so theoretically this is like a two-line change. Which makes it a nice testcase for UTF-8 compilation early on.

I have patches that get us to compiling using JSAPI compile-UTF-8 entrypoints (...that still inflate to UTF-16 internally) that still have some issues. But I doubt I'm far at this point from resolving those issues, then taking the further step of using the compile-UTF-8-directly entrypoints.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1553502 - Add a preference to (...eventually) control whether DOM worker scripts are compiled directly from UTF-8 without inflating. r=bzbarsky

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Bug 1553502 - Implement ScriptLoader::ConvertToUTF8. r=bzbarsky

Depends on D32254

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Bug 1553502 - Make DOM workers' ScriptLoadInfo class use member initializers instead of performing the same initializations in the constructor, for greater readability. r=bzbarsky

Depends on D32255

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Bug 1553502 - Allow DOM workers' ScriptLoadInfo to store and evaluate either UTF-8 or UTF-16 data, depending whether dom.worker.script_loader.utf8_parsing.enabled is true. r=bzbarsky

Depends on D32256

Comment 5

[Jeff Walden [:Waldo]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a5303035ce25de2e5bd8e82224ef029ebfb6be5 for a try-run of essentially these patches (and some other bugwork some of which prerequisite to these patches).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f43362b707d4
Add a preference to (...eventually) control whether DOM worker scripts are compiled directly from UTF-8 without inflating.  r=bzbarsky

Comment 7

[Jeff Walden [:Waldo]]

(landing the pref alone in advance of everything else, touching and untouching StaticPrefList.h is a wonderful way to clobber every stupid time)

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f43362b707d4

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1337df4d9d11
Implement ScriptLoader::ConvertToUTF8.  r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/20f03bc56440
Make DOM workers' ScriptLoadInfo class use member initializers instead of performing the same initializations in the constructor, for greater readability.  r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/492f35b04474
Allow DOM workers' ScriptLoadInfo to store and evaluate either UTF-8 or UTF-16 data, depending whether dom.worker.script_loader.utf8_parsing.enabled is true.  r=bzbarsky

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1337df4d9d11
https://hg.mozilla.org/mozilla-central/rev/20f03bc56440
https://hg.mozilla.org/mozilla-central/rev/492f35b04474