Compile DOM worker scripts directly from UTF-8, behind a pref

RESOLVED FIXED

Status

()

task
P3
normal
RESOLVED FIXED
Last month
10 days ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

(Blocks 1 bug, Regressed 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox69 affected)

Details

Attachments

(4 attachments)

Assignee

Description

Last month

Worker scripts are UTF-8 when downloaded, and read from cache they're UTF-8 as well, so theoretically this is like a two-line change. Which makes it a nice testcase for UTF-8 compilation early on.

I have patches that get us to compiling using JSAPI compile-UTF-8 entrypoints (...that still inflate to UTF-16 internally) that still have some issues. But I doubt I'm far at this point from resolving those issues, then taking the further step of using the compile-UTF-8-directly entrypoints.

Assignee

Updated

Last month
Blocks: 1543517
Component: JavaScript Engine → DOM: Workers
Summary: Compile DOM worker scripts directly from UTF-8 → Compile DOM worker scripts directly from UTF-8, behind a pref
Assignee

Comment 5

Last month

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a5303035ce25de2e5bd8e82224ef029ebfb6be5 for a try-run of essentially these patches (and some other bugwork some of which prerequisite to these patches).

Priority: -- → P3

Comment 6

Last month
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f43362b707d4
Add a preference to (...eventually) control whether DOM worker scripts are compiled directly from UTF-8 without inflating.  r=bzbarsky
Assignee

Comment 7

Last month

(landing the pref alone in advance of everything else, touching and untouching StaticPrefList.h is a wonderful way to clobber every stupid time)

Keywords: leave-open

Comment 9

Last month
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/autoland/rev/1337df4d9d11
Implement ScriptLoader::ConvertToUTF8.  r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/20f03bc56440
Make DOM workers' ScriptLoadInfo class use member initializers instead of performing the same initializations in the constructor, for greater readability.  r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/492f35b04474
Allow DOM workers' ScriptLoadInfo to store and evaluate either UTF-8 or UTF-16 data, depending whether dom.worker.script_loader.utf8_parsing.enabled is true.  r=bzbarsky
Assignee

Updated

28 days ago
Status: ASSIGNED → RESOLVED
Closed: 28 days ago
Keywords: leave-open
Resolution: --- → FIXED
Assignee

Updated

10 days ago
Regressions: 1559633
You need to log in before you can comment on or make changes to this bug.