1553534 - [about:addons] Addon details page tabs need styling for dark mode

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Kestrel]

Attachment: White tabs in addon details page with dark mode

Details page tabs are white in dark mode and hovering over them has black text on dark background.

Comment 1

[Kestrel]

Attachment: Bug 1553534 - Apply in-content colors to about:addons tab deck for dark mode compatibility

Tabs use --in-content-box colors as seen in common.css, about:preferences Certificate viewer and about:logins.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71d648e912ef
Apply in-content colors to about:addons tab deck for dark mode compatibility r=jaws

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/71d648e912ef

Comment 4

[CosminB]

Attachment: Bug1553534.gif

This issue is verified as fixed on Firefox 69.0a1 (20190620220631) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.

Comment 5

[Rob Wu [:robwu]]

Comment on attachment 9072792 [details]
Bug 1553534 - Apply in-content colors to about:addons tab deck for dark mode compatibility

Beta/Release Uplift Approval Request

• User impact if declined: When dark themes are enabled, the tabs on the about:addons details view are bright and unreadable upon hover.
  This is the only major defect in dark theme support in HTML about:addons.

Note: Dark themes are disabled by default (bug 1519547), but since the rest of about:addons has proper dark theme support, it would be nice to have full dark theme support in the HTML about:addons for users who opt in to this feature.

• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only colors have been changed by the patch. The fix has been verified on Nightly by QA, and I just confirmed that the standard (light) theme still looks reasonable.
• String changes made/needed: none

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9072792 [details]
Bug 1553534 - Apply in-content colors to about:addons tab deck for dark mode compatibility

about:addons css fixes for dark mode compat, approved for 68 rc1

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/670e994baec4

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/670e994baec4

Comment 9

[Alex Cornestean]

Verified the fix on the latest Beta Release Candidate (68.0 / 20190701181138) and ESR (68.0esr / 20190704173630) under Windows 10 Pro 64-bit and macOS 10.14.5 Mojave, obtaining the exact results documented in Comment 4.

However, before changing the status of the 68 and esr68 tracking flags to Verified, can you please confirm whether the ‘Options’ tab from the detail view of extensions should have a white background? Is this the intended behavior?

This can be clearly seen in the posted image of Comment 4 and those are the results I have obtained throughout the validation of this fix.

Comment 10

[Kestrel]

The tab page contents is unrelated to this bug which is only concerned with the tab button styling. Extensions have full control over their settings page and only a few currently support dark mode (eg Decentraleyes) so this is expected behavior.

Comment 11

[Alex Cornestean]

As per the above comment, closing the issue as Verified.