1553681 - Reundant confirmation dialog for reloading the page

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Botond Ballo [:botond]]

STR:

1. Have a Treeherder page open.
2. Wait for a site update, which causes a blue header bar to appear that says something like "Reload to update the page", with a red "Reload" button.
3. Click the red "Reload" button.

Actual results:

I get a dialog asking if I want to reload the page.

Expected results:

I think my intentions are pretty clear when I press the red "Reload" button; no need for a dialog.

Comment 1

[Cameron Dawson [:camd]]

Yeah, that makes sense. :)

Comment 2

[Cameron Dawson [:camd]]

The code for this is here: https://github.com/mozilla/treeherder/blob/256c2444399d0b76446f95c224f1cc0f0ba85773/ui/job-view/headerbars/SecondaryNavBar.jsx#L237

Comment 3

[janeln]

Hi, I am an outreachy applicant, can I start work on this issue?

Comment 4

[Cameron Dawson [:camd]]

Hi Janeln-- We actually closed down this project to new applicants late this morning. We have more folks than we can manage at the moment. My apologies.

Comment 5

[Cameron Dawson [:camd]]

Claudia, since you inquired yesterday, I have assigned this bug to you. Please let me know if you have any questions. :)

Comment 6

[Sarah Clements [:sclements]]

Claudia, were you still planning to work on this bug?

Comment 7

[shavindra]

I would like to look in to this if its ok?

Comment 8

[Botond Ballo [:botond]]

Hi shavindra, yes, it looks like this bug is available for taking. I'm not the right person to mentor it though, let's ask Sarah.

Comment 9

[Sarah Clements [:sclements]]

I'll assign this bug to you Shavindra (if you later decide you don't want to work on it, please remove your name from "assignee"). Please take a look at our docs before you get started: https://treeherder.readthedocs.io/index.html

camd will be able to answer questions and review your pull request - you'll need to mention him in the github pr.

Comment 10

[shavindra]

Attachment: firefox_lktNbXpxaw.png

I cannot see a red button. Initial Text says "Treeherder update available" It's only the Title when you hover that says "reload...".

When I click on the text "Treeheder update available" button I get the confirmation window.

Is the purpose of this is to just remove the confirmation dialog? Or something else?

Comment 11

[Cameron Dawson [:camd]]

Shavindra: Yes, it's just a matter of removing that confirmation dialog in the screenshot and doing the reload as soon as you click the first button.

Comment 12

[shavindra]

Attachment: GitHub Pull Request

Comment 13

[shavindra]

It's ready for review. I could also add a test for App_test.jsx too. But might require more changes to the _test file. Wasn't sure if it's necessary. Let me know if it's need to be done?

Comment 14

[Cameron Dawson [:camd]]

I will review your changes in github.

Comment 15

[shavindra]

I can't seem have option change the Status: Resolved > Fixed. I only seem to get WORKSFORME?. I've read the docs but seems nothing in there that suggest to help me to say finalize application / Trigger a release or anything like that?