Remove the clip chain stack during the prepare_prims pass in WR

RESOLVED FIXED in Firefox 69

Status

()

task
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: gw, Assigned: gw)

Tracking

unspecified
mozilla69
Points:
---

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment)

No description provided.
Assignee: nobody → gwatson

During the visibility pass, the main clip chain instance for each
primitive is created. In the prim prepare pass, a clip chain instance
is generated for each segment (of primitives that are segmented).

This previously required maintaining the active clip chain stack
during both passes. However, this is not ideal for a number of
reasons: the code is somewhat complicated / error prone and the
segment clip chain building step does more work than required.

This patch changes the segment clip chain building code to set up
the active clip nodes based on the result of the initial clip
chain built for the overall primitive during the visibility pass.

This means that it's no longer necessary to maintain the active
clip chain stack during the prepare pass. This simplifies some
upcoming picture caching changes related to avoiding redundant
cache invalidations, which is the main motivation for the change.

Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e69ff803ac9
Remove the clip chain stack during the prepare_prims pass in WR. r=kvark,nical
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.