1553778 - thunderbird adjustments for toolbarbutton de-xbl

Status: RESOLVED FIXED

Description

[Magnus Melin [:mkmelin]]

We have a few places where #toolbarbutton is referenced. Need to fix that when bug 1519577 lands.

Found two places, one seems we can just remove (the elements are already toolbarbuttons) and one test adjustment.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1553778_msgHeaderView-button.patch

Comment 2

[Khushil Mistry [:khushil324]]

Comment on attachment 9066997 [details] [diff] [review]
bug1553778_msgHeaderView-button.patch

Review of attachment 9066997 [details] [diff] [review]:
-----------------------------------------------------------------

mochi test is working fine. Need changes for Mozmill tests. I guess we should add those changes over here.

Comment 3

[Jorg K (GMT+2)]

I'll switch off the failing mozmill/quick-filter-bar/test-display-issues.js | test-display-issues.js::test_buttons_collapse_and_expand here.

The error is: EXCEPTION: mc.window.document.getAnonymousNodes(...) is null

So clearly something isn't XBL any more. Sorry, I have worse bustage, so I'll leave this to Magnus.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b1dd67d46b1
Thunderbird adjustments for toolbarbutton de-XBL in bug 1519577. rs=bustage-fix,jorgk
https://hg.mozilla.org/comm-central/rev/a4594c5cec7d
temporarily disable test-display-issues.js::test_buttons_collapse_and_expand. rs=bustage-fix

Comment 5

[Jorg K (GMT+2)]

Additionally to comment #3 there is also a failure in the Mochitests:
TEST-UNEXPECTED-FAIL | comm/mail/components/extensions/test/browser/browser_ext_browserAction.js | Uncaught exception - at chrome://mochitests/content/browser/comm/mail/components/extensions/test/browser/browser_ext_browserAction.js:21 - TypeError: Argument 1 of Window.getComputedStyle is not an object.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d5d5ade9fbd6
adjust mail/components/extensions/test/browser/browser_ext_browserAction.js to toolbarbutton de-xbl. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/1aa9b4cb10ab
fix and re-enable test_buttons_collapse_and_expand. rs=bustage-fix

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/222e2a74d5da
adjust test-ttachment-menus.js and test-attachment.js for the toolbarbutton de-xbl. rs=bustage-fix

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8187a5f97b44
adjust test-attachment-reminder.js for toolbarbutton de-xbl. rs=bustage-fix

Comment 9

[Magnus Melin [:mkmelin]]

I think we're done here. Bug 1554300 is for the calendar issue.

Comment 10

[Jorg K (GMT+2)]

Aceman, can you please do a PLR on all the patches landed here:

https://hg.mozilla.org/comm-central/rev/8b1dd67d46b1
Thunderbird adjustments for toolbarbutton de-XBL in bug 1519577. rs=bustage-fix,jorgk

https://hg.mozilla.org/comm-central/rev/d5d5ade9fbd6
adjust mail/components/extensions/test/browser/browser_ext_browserAction.js to toolbarbutton de-xbl. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/1aa9b4cb10ab
fix and re-enable test_buttons_collapse_and_expand. rs=bustage-fix

https://hg.mozilla.org/comm-central/rev/222e2a74d5da
adjust test-ttachment-menus.js and test-attachment.js for the toolbarbutton de-xbl. rs=bustage-fix

https://hg.mozilla.org/comm-central/rev/8187a5f97b44
adjust test-attachment-reminder.js for toolbarbutton de-xbl. rs=bustage-fix

Comment 11

[:aceman]

How, where are the patches attached?

Comment 12

[Jorg K (GMT+2)]

Can you review the changesets quoted in comment #10 or do I really have to scrape they of the repository and attach them here? :-(

Comment 13

[:aceman]

(In reply to Jorg K (GMT+2) from comment #10)

https://hg.mozilla.org/comm-central/rev/8b1dd67d46b1
Thunderbird adjustments for toolbarbutton de-XBL in bug 1519577. rs=bustage-fix,jorgk

https://hg.mozilla.org/comm-central/rev/d5d5ade9fbd6
adjust mail/components/extensions/test/browser/browser_ext_browserAction.js to toolbarbutton de-xbl. rs=bustage-fix

https://hg.mozilla.org/comm-central/rev/1aa9b4cb10ab
fix and re-enable test_buttons_collapse_and_expand. rs=bustage-fix

https://hg.mozilla.org/comm-central/rev/222e2a74d5da
adjust test-ttachment-menus.js and test-attachment.js for the toolbarbutton de-xbl. rs=bustage-fix

https://hg.mozilla.org/comm-central/rev/8187a5f97b44
adjust test-attachment-reminder.js for toolbarbutton de-xbl. rs=bustage-fix

r=aceman

I'm not happy with the removal of get_menu_dropmarker() and I don't buy the argument, that it is easier to remember the class name than this special function of mozmill controller. It looks to me it is the same and using the function is also much shorter.