thunderbird adjustments for toolbarbutton de-xbl
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file)
|
3.05 KB,
patch
|
aceman
:
review+
|
Details | Diff | Splinter Review |
We have a few places where #toolbarbutton is referenced. Need to fix that when bug 1519577 lands.
Found two places, one seems we can just remove (the elements are already toolbarbuttons) and one test adjustment.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Comment 2•2 years ago
|
||
Comment on attachment 9066997 [details] [diff] [review] bug1553778_msgHeaderView-button.patch Review of attachment 9066997 [details] [diff] [review]: ----------------------------------------------------------------- mochi test is working fine. Need changes for Mozmill tests. I guess we should add those changes over here.
|
||
Comment 3•2 years ago
|
||
I'll switch off the failing mozmill/quick-filter-bar/test-display-issues.js | test-display-issues.js::test_buttons_collapse_and_expand here.
The error is: EXCEPTION: mc.window.document.getAnonymousNodes(...) is null
So clearly something isn't XBL any more. Sorry, I have worse bustage, so I'll leave this to Magnus.
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/8b1dd67d46b1 Thunderbird adjustments for toolbarbutton de-XBL in bug 1519577. rs=bustage-fix,jorgk https://hg.mozilla.org/comm-central/rev/a4594c5cec7d temporarily disable test-display-issues.js::test_buttons_collapse_and_expand. rs=bustage-fix
|
|
||
Updated•2 years ago
|
|
|
||
Comment 5•2 years ago
|
||
Additionally to comment #3 there is also a failure in the Mochitests:
TEST-UNEXPECTED-FAIL | comm/mail/components/extensions/test/browser/browser_ext_browserAction.js | Uncaught exception - at chrome://mochitests/content/browser/comm/mail/components/extensions/test/browser/browser_ext_browserAction.js:21 - TypeError: Argument 1 of Window.getComputedStyle is not an object.
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/d5d5ade9fbd6 adjust mail/components/extensions/test/browser/browser_ext_browserAction.js to toolbarbutton de-xbl. rs=bustage-fix https://hg.mozilla.org/comm-central/rev/1aa9b4cb10ab fix and re-enable test_buttons_collapse_and_expand. rs=bustage-fix
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/222e2a74d5da adjust test-ttachment-menus.js and test-attachment.js for the toolbarbutton de-xbl. rs=bustage-fix
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/8187a5f97b44 adjust test-attachment-reminder.js for toolbarbutton de-xbl. rs=bustage-fix
|
|
Assignee | |
Comment 9•2 years ago
|
||
I think we're done here. Bug 1554300 is for the calendar issue.
|
|
||
Comment 10•2 years ago
|
||
Aceman, can you please do a PLR on all the patches landed here:
https://hg.mozilla.org/comm-central/rev/8b1dd67d46b1
Thunderbird adjustments for toolbarbutton de-XBL in bug 1519577. rs=bustage-fix,jorgk
https://hg.mozilla.org/comm-central/rev/d5d5ade9fbd6
adjust mail/components/extensions/test/browser/browser_ext_browserAction.js to toolbarbutton de-xbl. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/1aa9b4cb10ab
fix and re-enable test_buttons_collapse_and_expand. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/222e2a74d5da
adjust test-ttachment-menus.js and test-attachment.js for the toolbarbutton de-xbl. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/8187a5f97b44
adjust test-attachment-reminder.js for toolbarbutton de-xbl. rs=bustage-fix
|
|
||
Comment 12•2 years ago
|
||
Can you review the changesets quoted in comment #10 or do I really have to scrape they of the repository and attach them here? :-(
|
||
Comment 13•2 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #10)
https://hg.mozilla.org/comm-central/rev/8b1dd67d46b1
Thunderbird adjustments for toolbarbutton de-XBL in bug 1519577. rs=bustage-fix,jorgkhttps://hg.mozilla.org/comm-central/rev/d5d5ade9fbd6
adjust mail/components/extensions/test/browser/browser_ext_browserAction.js to toolbarbutton de-xbl. rs=bustage-fixhttps://hg.mozilla.org/comm-central/rev/1aa9b4cb10ab
fix and re-enable test_buttons_collapse_and_expand. rs=bustage-fixhttps://hg.mozilla.org/comm-central/rev/222e2a74d5da
adjust test-ttachment-menus.js and test-attachment.js for the toolbarbutton de-xbl. rs=bustage-fixhttps://hg.mozilla.org/comm-central/rev/8187a5f97b44
adjust test-attachment-reminder.js for toolbarbutton de-xbl. rs=bustage-fix
r=aceman
I'm not happy with the removal of get_menu_dropmarker() and I don't buy the argument, that it is easier to remember the class name than this special function of mozmill controller. It looks to me it is the same and using the function is also much shorter.
Description
•