Closed Bug 1553868 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16976 - [LayoutNG] Ensure that new formatting-context margins separates correctly.

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 16976 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16976
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[LayoutNG] Ensure that new formatting-context margins separates correctly.

When positioning a new formatting-context in the presence of adjoining
floats sometimes a "forced" BFC block-offset will be set twice.

When this new formatting-context was wrapped in a \<div> (a parent which
hadn't had its BFC block-offset resolved yet) we ran into a bug with our
state machine.

Upon the second time resolving the BFC block-offset the parent would
resolve its BFC block-offset to the previous "forced" BFC
block-offset.

Upon the final relayout the parent would set the first "forced" BFC
block-offset to its children causing an "infinite" loop (if we had a
loop driving this machinery.

This ensures we use the childs new BFC block-offset in this case.

Bug: 966278, 966214
Change-Id: I5da2f3e90b9d2ff78f124247f6f68cd3a289ae42

Reviewed-on: https://chromium-review.googlesource.com/1627692
WPT-Export-Revision: 5c7aa1a207b1eaf9be7873501a04475cd63a6873

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10dc40ccf61f
[wpt PR 16976] - [LayoutNG] Ensure that new formatting-context margins separate correctly., a=testonly

https://hg.mozilla.org/mozilla-central/rev/10dc40ccf61f

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream error] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.