1553905 - Samples build is failing

Status: RESOLVED FIXED

(NSS :: Documentation, defect, P3)

Description

[rks1986]

Attachment: makesample.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

I am trying to build/run/test nss samples here https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_Sample_Code

1. build nss (https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/Building)

2. hg update SAMPLES_BRANCH
3. cd samples
4. ./makesample.sh sample1 test Debug

Actual results:

gcc -g sample1.c -o sample1
-I/home/ravi/code/mozilla/nss/samples/../../dist/Debug/include -I/home/ravi/code/mozilla/nss/samples/../../dist/public/nss -lnspr4 -lc -lnss3 -lnssutil3 -lsmime3 -lplc4 -L/home/ravi/code/mozilla/nss/samples/../../dist/Debug/lib
sample1.c:6:10: fatal error: prprf.h: No such file or directory
#include <prprf.h>
^~~~~~~~~
compilation terminated.
Makefile:22: recipe for target 'sample1' failed
make: *** [sample1] Error 1

Expected results:

Tests should build and run.

This error is because of wrong location of nspr headers in samples/makesample.sh

The attached patch fixes this error.

Follow instructions to apply the patch

1. hg update SAMPLES_BRANCH
2. patch -Np0 < makesample.patch

3. you should see "patching file samples/makesample.sh"

The patch was generated using following command
$ LC_ALL=C TZ=UTC0 diff -Naur samples samples_fixed > makesample.patch

Comment 1

[J.C. Jones [:jcj] (he/him)]

Comment on attachment 9067131 [details] [diff] [review]
makesample.patch

Marcus, can you check this over for me? Thanks.

Comment 2

[Marcus Burghardt]

Comment on attachment 9067131 [details] [diff] [review]
makesample.patch

Looks good. Could you send it for Phabricator, please? Or would you like I push it for you?

Thanks,

Comment 3

[rks1986]

(In reply to Marcus Burghardt from comment #2)

Comment on attachment 9067131 [details] [diff] [review]
makesample.patch

Looks good. Could you send it for Phabricator, please? Or would you like I
push it for you?

Thanks,

Hi Markus, I dont think Phabricator is setup for SAMPLES_BRANCH. You can push it for me or point me to the instructions to make Phabricator work for the SAMPLES_BRANCH. Thanks

Comment 4

[Marcus Burghardt]

Hi rks,

Ok, we can push it soon.

Thanks,

Comment 5

[J.C. Jones [:jcj] (he/him)]

https://hg.mozilla.org/projects/nss/rev/f976ec68d63a835a8817546a557496600bd04baa

Comment 6

[J.C. Jones [:jcj] (he/him)]

Mmm, samples branch is at 3.27; might be worthwhile to merge back to it, too, soon. At any rate, thanks for the fix!