Closed Bug 1553919 Opened 5 years ago Closed 5 years ago

Remove eslint-json plugin from newtab

Categories

(Firefox :: Messaging System, task, P1)

Product:
Firefox
Component:
Messaging System
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 69
Iteration:
69.2 - May 27 - Jun 9
Tracking Flags:
Tracking Status
firefox68 --- unaffected
firefox69 --- fixed

People

(Reporter: k88hudson, Assigned: k88hudson)

References

Details

I'd recommend removing eslint-json in order to get our eslintrc closer to being compatible with mozilla central's linting. According to the author:

Is eslint really the best tool to lint my JSON?
Not really. eslint plugin interface wasn't designed to lint a completely different language but its interface is flexible enough to allow it. So this plugin is certainly unusual.

We could also consider porting it, but I'm not sure it's really worth it given that it only lints some schema files that are covered by tests anyway.

Assignee: nobody → khudson
Iteration: --- → 69.2 - May 27 - Jun 9
status-firefox68: --- → unaffected
status-firefox69: --- → affected
Priority: -- → P1

(This will be closed by Bug 1553917)

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.