1554095 - Block URL action doesn't work

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Recently introduced Block URL action doesn't work since there is no selected request

STR:

1. Load this page: http://janodvarko.cz/firebug/tests/601/Issue601.htm
2. Open DevTools select the Network panel
3. Click the POST button
4. Right click on the request in the Network panel and pick: Block URL
5. Click the POST button in the page again
6. The request isn't blocked -> BUG

If you select the request by clicking on it and consequently executing the "Block URL" action it works properly.

The problem is in this method:
https://searchfox.org/mozilla-central/rev/662de518b1686c4769320d6b8825ce4864c4eda0/devtools/client/netmonitor/src/actions/requests.js#111-122

getSelectedRequest(getState()); returns null

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Heng Yeow: I think this is caused by bug 1466598, can you please look at that?

Honza

Comment 2

[Cristian Fogel [:cfogel]]

Regression range:

• Last good build_date: 2019-05-17 17:46:47.191000 changeset: c94c54aff4669f52cebc76ddad34a76f4fafd03b
• First bad build_date: 2019-05-17 17:46:47.191000 changeset: c94c54aff4669f52cebc76ddad34a76f4fafd03b
  Pushlog link

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks Cristi!

@Heng Yeow, yep the bug 1466598 is in the push log

Honza

Comment 4

[Hengyeow (:tanhengyeow)]

Attachment: Bug 1554095 - Fix Block URL action. r=Honza

Comment 5

[Hengyeow (:tanhengyeow)]

Fixed the regression! Try looks good as well :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e80b2082da5
Fix Block URL action. r=Honza

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8e80b2082da5

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9067423 [details]
Bug 1554095 - Fix Block URL action. r=Honza

Beta/Release Uplift Approval Request

• User impact if declined: Manual HTTP request blocking doesn't work in the Network panel (DevTools)
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch, tested in Nightly, impact only on Web developers (not on regular Firefox users)
• String changes made/needed:

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9067423 [details]
Bug 1554095 - Fix Block URL action. r=Honza

netmonitor fix for 68.0b8

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6b2a8d526cd

Comment 11

[Cristian Fogel [:cfogel]]

Confirmed with 69.0a1 (2019-06-05) and 68.0b10.
Working fine on current versions as well, heh.