1554098 - RSS media enclosures type is not deduced from extension when missing

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, enhancement)

Description

[Guillaume Maudoux [:layus]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

Subscribe to a feed with a media:content enclosure. For example this one https://www.mediapart.fr/articles/feed

Actual results:

The image was not displayed inline, as is the case with other rss feeds.
After investigation, it turns out that the stream does not provide a "type" tag in the media:content element, only the url tag.

Expected results:

As the image url ends with .jpg, Thunderbird could make a more educated guess than the default application/unknown from https://dxr.mozilla.org/comm-central/rev/2a29ee0adb310b54a6a2df72034953fed8f2b043/comm/mailnews/extensions/newsblog/content/FeedItem.js#400 . The image would thus be displayed normally.

It makes sense to perform the guess, as the type tag is not mandatory as per media-rss spec.

Comment 1

[alta88]

Attachment: mediaType.patch

Sure, why not.

Comment 2

[Guillaume Maudoux [:layus]]

Comment on attachment 9067421 [details] [diff] [review]
mediaType.patch

Review of attachment 9067421 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for providing such a quick fix !

The patch looks good to me (quite obviously), but I did not test it.
I could not find the required js interface. I was looking for nsIMime in dxr. Got bitten by case sensitivity.

Thanks again :-)

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9067421 [details] [diff] [review]
mediaType.patch

Review of attachment 9067421 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9067421 [details] [diff] [review]
mediaType.patch

Beta material, right?

Comment 5

[alta88]

yes, thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/650172622d99
deduce RSS media enclosures type from extension when missing. r=mkmelin

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68 beta:
https://hg.mozilla.org/releases/comm-beta/rev/292a3196ae5b6df988bcf5b56d3419449dfa80be

Comment 8

[Guillaume Maudoux [:layus]]

Finally got a chance to test it. It is working perfectly, thanks !