1554102 - The flow input values from about:welcome page are not set for custom fxa endpoint

Status: RESOLVED WORKSFORME

(Firefox :: Messaging System, defect)

Description

[Alin Ilea, Desktop QA]

Attachment: Actual result.png

Affected versions:

Tested on Nightly 69.0a1 (2019-05-23)

Affected platforms:

Tested on Mac OS 10.14 and Windows 10

Prerequisites:
To be able to see the about:welcome page on a version where this is not implemented please go to about:config and set:

identity.fxaccounts.autoconfig.uri to https://latest.dev.lcip.org/
browser.newtabpage.activity-stream.fxaccounts.endpoint to https://latest.dev.lcip.org/
Restart the browser.

Steps:

1. Go to about:welcome page
2. Click Menu button
3. Select Web developer option
4. Select Inspector option
5. Inspect "Enter email" field
6. Check the following inputs:

• input name = "device_id"
• input name = "flow_id"
• input name = "flow_begin_time"

Expected result:

The three inputs show a numeric value (always random number), this values should never show "0" or blank.

Actual result:

For input name = "device_id" and input name = "flow_id" value is blank
For input name = "flow_begin_time" value = 0

Regression range:

With the Nightly build 69.0a1(2019-05-22) the issue is not reproducible, but with Nightly build 69.0a1(2019-05-23) the issue is reproducible.

Note:

Maybe this bug can be related to this one:

https://bugzilla.mozilla.org/show_bug.cgi?id=1553205

Comment 2

[Ed Lee :Mardak]

Hmm.. Bug 1553205 was fixed for the 2019-05-22 build so there wasn't an explicit change for the 2019-05-23 build regarding the flow. Is this still happening with the latest nightly?

Comment 3

[Alin Ilea, Desktop QA]

(In reply to Ed Lee :Mardak from comment #2)

Hmm.. Bug 1553205 was fixed for the 2019-05-22 build so there wasn't an explicit change for the 2019-05-23 build regarding the flow. Is this still happening with the latest nightly?

Hi,

I've retested on latest Nightly build 69.0a1 (2019-05-28) and the issue is still reproducible.
The result is the same:
For input name = "device_id" and input name = "flow_id" value is blank
For input name = "flow_begin_time" value = 0

Comment 4

[Ed Lee :Mardak]

Ah, this looks like it's an issue specific to setting browser.newtabpage.activity-stream.fxaccounts.endpoint to https://latest.dev.lcip.org/

It ends up getting 404 for https://latest.dev.lcip.org//metrics-flow?… (note the double slash) instead of https://latest.dev.lcip.org/metrics-flow?… (this url will 401 instead of 404 when plain clicked on from bugzilla)

Notice that https://accounts.firefox.com//metrics-flow?… and https://accounts.firefox.com/metrics-flow?… both result in 401 instead of the double returning 404.

Confusingly firefox.js pref has a trailing slash while the getStringPref call defaults with no slash:
https://searchfox.org/mozilla-central/search?q=fxaccounts.endpoint

Comment 5

[Ed Lee :Mardak]

I suppose perhaps the QA instruction should be to set browser.newtabpage.activity-stream.fxaccounts.endpoint to https://latest.dev.lcip.org for testing.

Do you see flow values when you set the pref without trailing slash?

Comment 6

[Alin Ilea, Desktop QA]

(In reply to Ed Lee :Mardak from comment #5)

I suppose perhaps the QA instruction should be to set browser.newtabpage.activity-stream.fxaccounts.endpoint to https://latest.dev.lcip.org for testing.

Do you see flow values when you set the pref without trailing slash?

Yes, if I set the pref without trailing slash for browser.newtabpage.activity-stream.fxaccounts.endpoint to https://latest.dev.lcip.org it works ok, flow values are there.
Thanks.

Comment 7

[Alin Ilea, Desktop QA]

Based on the fact that if user set the pref without trailing slash for:
browser.newtabpage.activity-stream.fxaccounts.endpoint to https://latest.dev.lcip.org
and
identity.fxaccounts.autoconfig.uri to https://latest.dev.lcip.org it works ok, flow values appears, I will close this bug as Resolved-Worksforme.