Closed Bug 1554111 Opened 1 year ago Closed 1 year ago

Add js/src/wasm/cranelift/src/ to the rustfmt list

Categories

(Firefox Build System :: Lint and Formatting, task)

task
Not set
normal

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

No description provided.

It won't be run at review phase because it isn't set up but it should not be hard to do

Blocks: 1551078

Nice, just a few preliminary questions:

  • does it run rustfmt with some specific parameters?
  • what command line controls this? Would that be ./mach lint -l rustfmt js/src/wasm/cranelift --fix ?
  • if I ran this command now, would it produce a diff or keep the code as it is? (probably implied by the first question; when I run cargo fmt in js/src/wasm/cranelift no changes are produced) If it produced a diff, can you make a second patch that includes these formatting changes, please?
Flags: needinfo?(sledru)

(In reply to Benjamin Bouvier [:bbouvier] from comment #3)

  • does it run rustfmt with some specific parameters?

nope, defaults args (+ --check)

  • what command line controls this? Would that be ./mach lint -l rustfmt js/src/wasm/cranelift --fix ?

yeah with the patch
./mach lint -l rustfmt js/src/wasm/cranelift --fix -n
without the patch (see the -n)

  • if I ran this command now, would it produce a diff or keep the code as it is? (probably implied by the first question; when I run cargo fmt in js/src/wasm/cranelift no changes are produced) If it produced a diff, can you make a second patch that includes these formatting changes, please?

./mach lint -l rustfmt js/src/wasm/cranelift -n
shows the issues (none)
./mach lint -l rustfmt js/src/wasm/cranelift --fix -n
fixes them

Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a24881392ee
Add js/src/wasm/cranelift/src/ to the rustfmt list r=bbouvier
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.