Problems updating legacy extensions
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Tracking
(thunderbird68 fixed, thunderbird69 fixed)
People
(Reporter: neil, Assigned: darktrojan)
References
Details
Attachments
(1 file)
3.23 KB,
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
Steps to reproduce problem:
- Install legacy extension
- Restart as prompted
- Install update to legacy extension
Actual result: No prompt to restart
Expected result: Prompt to restart
Additionally, manually restarting does not actually update the extension, unless you use Services.appinfo.invalidateCachesOnRestart()
first, or you close Thunderbird and start it using MOZ_PURGE_CACHES=1
or --purgecaches
. (I don't know whether the Restart option in the Addons Manager automatically does this.)
Reporter | ||
Comment 1•5 years ago
|
||
(Changing version to 68 as I observed this with treeherder beta builds on both Mac on Linux.)
Comment 2•5 years ago
|
||
I had the same problem the other day. In the end the changes where acknowledged when I edited manifest.json. I also had the impression that removing the extension actually doesn't remove the XPI file. In the end, I removed it in the file manager, a new version would take effect.
Assignee | ||
Comment 3•5 years ago
|
||
Which prompt are we talking about Neil? The pop-up panel thing, or a different one?
I've found some places where we should clear the start-up cache but don't, so I'll post a patch for that.
Assignee | ||
Comment 4•5 years ago
|
||
This clears the startup cache if there was a different version of the extension installed, or if on installation for the first time.
Comment 5•5 years ago
|
||
Comment on attachment 9069579 [details] [diff] [review] 1554127-startup-cache-1.diff Review of attachment 9069579 [details] [diff] [review]: ----------------------------------------------------------------- r=mkmelin
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/72ff6b1ef248
Invalidate the start-up cache on legacy extension installation. r=mkmelin
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Description
•