Closed Bug 1554127 Opened 5 years ago Closed 5 years ago

Problems updating legacy extensions

Categories

(Thunderbird :: Add-Ons: Extensions API, defect)

defect
Not set
normal

Tracking

(thunderbird68 fixed, thunderbird69 fixed)

RESOLVED FIXED
Thunderbird 69.0
Tracking Status
thunderbird68 --- fixed
thunderbird69 --- fixed

People

(Reporter: neil, Assigned: darktrojan)

References

Details

Attachments

(1 file)

Steps to reproduce problem:

  1. Install legacy extension
  2. Restart as prompted
  3. Install update to legacy extension

Actual result: No prompt to restart

Expected result: Prompt to restart

Additionally, manually restarting does not actually update the extension, unless you use Services.appinfo.invalidateCachesOnRestart() first, or you close Thunderbird and start it using MOZ_PURGE_CACHES=1 or --purgecaches. (I don't know whether the Restart option in the Addons Manager automatically does this.)

(Changing version to 68 as I observed this with treeherder beta builds on both Mac on Linux.)

Version: 67 → 68

I had the same problem the other day. In the end the changes where acknowledged when I edited manifest.json. I also had the impression that removing the extension actually doesn't remove the XPI file. In the end, I removed it in the file manager, a new version would take effect.

Flags: needinfo?(geoff)

Which prompt are we talking about Neil? The pop-up panel thing, or a different one?

I've found some places where we should clear the start-up cache but don't, so I'll post a patch for that.

Flags: needinfo?(geoff)

This clears the startup cache if there was a different version of the extension installed, or if on installation for the first time.

Attachment #9069579 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9069579 [details] [diff] [review]
1554127-startup-cache-1.diff

Review of attachment 9069579 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin
Attachment #9069579 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9069579 - Flags: approval-comm-beta+
Target Milestone: --- → Thunderbird 69.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/72ff6b1ef248
Invalidate the start-up cache on legacy extension installation. r=mkmelin

Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Assignee: nobody → geoff
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: